]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
posix-timers: Add cond_resched() to posix_timer_add() search loop
authorEric Dumazet <edumazet@google.com>
Sat, 8 Mar 2025 16:48:17 +0000 (17:48 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 13 Mar 2025 11:07:16 +0000 (12:07 +0100)
With a large number of POSIX timers the search for a valid ID might cause a
soft lockup on PREEMPT_NONE/VOLUNTARY kernels.

Add cond_resched() to the loop to prevent that.

[ tglx: Split out from Eric's series ]

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/all/20250214135911.2037402-2-edumazet@google.com
Link: https://lore.kernel.org/all/20250308155623.635612865@linutronix.de
kernel/time/posix-timers.c

index 24d7eab1048b8b89a406e4e316bedeca95b065e8..de252534215c7d6cf5e17541772b536f71d78e48 100644 (file)
@@ -144,6 +144,7 @@ static int posix_timer_add(struct k_itimer *timer)
                        return id;
                }
                spin_unlock(&hash_lock);
+               cond_resched();
        }
        /* POSIX return code when no timer ID could be allocated */
        return -EAGAIN;