]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
fix typo/thinko in get_random_bytes()
authorLuck, Tony <tony.luck@intel.com>
Wed, 16 Nov 2011 18:50:56 +0000 (10:50 -0800)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Fri, 17 Aug 2012 19:36:02 +0000 (15:36 -0400)
commit bd29e568a4cb6465f6e5ec7c1c1f3ae7d99cbec1 upstream.

If there is an architecture-specific random number generator we use it
to acquire randomness one "long" at a time.  We should put these random
words into consecutive words in the result buffer - not just overwrite
the first word again and again.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/char/random.c

index 6da0696c963078a296bd4189a1486578a0bbba53..df4eb6ded57c9fa2e6e74aedabe0806f6cb78c25 100644 (file)
@@ -934,7 +934,7 @@ void get_random_bytes(void *buf, int nbytes)
                if (!arch_get_random_long(&v))
                        break;
 
-               memcpy(buf, &v, chunk);
+               memcpy(p, &v, chunk);
                p += chunk;
                nbytes -= chunk;
        }