* NEWS: Mention the bug fix.

* src/groups.sh: Don't hide a write failure.
Reported by Iain Calder <ic56@rogers.com>.

diff --git a/ChangeLog b/ChangeLog
index 45d7f556d5179776b05a344b589ab3d34ae12056..7586f546266137a65f54bb3d4f30af39b4a83484 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-09-26  Jim Meyering  <jim@meyering.net>
+
+       * NEWS: Mention the bug fix.
+       * src/groups.sh: Don't hide a write failure.
+       Reported by Iain Calder <ic56@rogers.com>.
+
 2006-09-25  Jim Meyering  <jim@meyering.net>
 
        * src/chown.c (usage): Clarify --dereference description.

diff --git a/NEWS b/NEWS
index ab9386804dd1ea0466682b1c872058666dd72994..50fbcc5f7bb0544a763370090941ca611d545766 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -22,6 +22,9 @@ GNU coreutils NEWS                                    -*- outline -*-
   With --verbose (-v), cp and mv would sometimes generate no output,
   or neglect to report file removal.
 
+  "groups user" now exits nonzero when it gets a write error.
+
+
 * Major changes in release 6.2 (2006-09-18) [stable candidate]
 
 ** Changes in behavior

diff --git a/src/groups.sh b/src/groups.sh
index c9acf82ecd246e427e955030a7b204c3bf8636e1..dc64d12f1e5204856a2676af0989bec9cb0cabcd 100755 (executable)
--- a/src/groups.sh
+++ b/src/groups.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 # groups -- print the groups a user is in
-# Copyright (C) 1991, 1997, 2000, 2002, 2004 Free Software Foundation, Inc.
+# Copyright (C) 1991, 1997, 2000, 2002, 2004, 2006 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -61,7 +61,7 @@ else
     groups=`id -Gn -- $name`
     status=$?
     if test $status = 0; then
-      echo $name : $groups
+      echo $name : $groups || fail=1
     else
       fail=$status
     fi