lib/fields.c: valid_field(): Return early on error

Signed-off-by: Alejandro Colomar <alx@kernel.org>

diff --git a/lib/fields.c b/lib/fields.c
index 818d1c593b84280f12d47634748638354b181110..625a8f588c7dc75742da7d33b80715ff9dbe02a7 100644 (file)
--- a/lib/fields.c
+++ b/lib/fields.c
@@ -48,13 +48,11 @@ valid_field_(const char *field, const char *illegal)
        /* Search if there are non-printable or control characters */
        for (cp = field; !streq(cp, ""); cp++) {
                unsigned char c = *cp;
+               if (iscntrl(c))
+                       return -1;
                if (!isprint (c)) {
                        err = 1;
                }
-               if (iscntrl (c)) {
-                       err = -1;
-                       break;
-               }
        }
 
        return err;