]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t5500, t5601: skip tests which exercise paths with '[::1]' on Cygwin
authorPatrick Steinhardt <ps@pks.im>
Wed, 16 Oct 2024 08:13:10 +0000 (10:13 +0200)
committerTaylor Blau <me@ttaylorr.com>
Wed, 16 Oct 2024 21:00:49 +0000 (17:00 -0400)
Parsing repositories which contain '[::1]' is broken on Cygwin. It seems
as if Cygwin is confusing those as drive letter prefixes or something
like this, but I couldn't deduce the actual root cause.

Mark those tests as broken for now.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
t/t5500-fetch-pack.sh
t/t5601-clone.sh

index 605f17240c191a0db573096c82638934a6ae0868..416522c86ada3088240b9985472ec05c9f83d4e4 100755 (executable)
@@ -774,7 +774,7 @@ do
        # file with scheme
        for p in file
        do
-               test_expect_success !MINGW "fetch-pack --diag-url $p://$h/$r" '
+               test_expect_success !WINDOWS "fetch-pack --diag-url $p://$h/$r" '
                        check_prot_path $p://$h/$r $p "/$r"
                '
                test_expect_success MINGW "fetch-pack --diag-url $p://$h/$r" '
@@ -784,7 +784,7 @@ do
                        check_prot_path $p:///$r $p "/$r"
                '
                # No "/~" -> "~" conversion for file
-               test_expect_success !MINGW "fetch-pack --diag-url $p://$h/~$r" '
+               test_expect_success !WINDOWS "fetch-pack --diag-url $p://$h/~$r" '
                        check_prot_path $p://$h/~$r $p "/~$r"
                '
                test_expect_success MINGW "fetch-pack --diag-url $p://$h/~$r" '
@@ -806,11 +806,17 @@ do
        p=ssh
        for h in host [::1]
        do
-               test_expect_success "fetch-pack --diag-url $h:$r" '
+               expectation="success"
+               if test_have_prereq CYGWIN && test "$h" = "[::1]"
+               then
+                       expectation="failure"
+               fi
+
+               test_expect_$expectation "fetch-pack --diag-url $h:$r" '
                        check_prot_host_port_path $h:$r $p "$h" NONE "$r"
                '
                # Do "/~" -> "~" conversion
-               test_expect_success "fetch-pack --diag-url $h:/~$r" '
+               test_expect_$expectation "fetch-pack --diag-url $h:/~$r" '
                        check_prot_host_port_path $h:/~$r $p "$h" NONE "~$r"
                '
        done
index 5d7ea147f1abc5ffae19ad093f8e12c3427a970a..9fe665eadfb685f2cc9937a1dd5ec005a0d50fb7 100755 (executable)
@@ -530,10 +530,17 @@ do
        '
 done
 
+# Parsing of paths that look like IPv6 addresses is broken on Cygwin.
+expectation_for_ipv6_tests=success
+if test_have_prereq CYGWIN
+then
+       expectation_for_ipv6_tests=failure
+fi
+
 #ipv6
 for repo in rep rep/home/project 123
 do
-       test_expect_success "clone [::1]:$repo" '
+       test_expect_$expectation_for_ipv6_tests "clone [::1]:$repo" '
                test_clone_url [::1]:$repo ::1 "$repo"
        '
 done
@@ -542,7 +549,7 @@ test_expect_success "clone host:/~repo" '
        test_clone_url host:/~repo host "~repo"
 '
 
-test_expect_success "clone [::1]:/~repo" '
+test_expect_$expectation_for_ipv6_tests "clone [::1]:/~repo" '
        test_clone_url [::1]:/~repo ::1 "~repo"
 '