xfs: repair inode btrees

Source kernel commit: dbfbf3bdf639a20da7d5fb390cd2e197d25aa418

Use the rmapbt to find inode chunks, query the chunks to compute hole
and free masks, and with that information rebuild the inobt and finobt.
Refer to the case study in
Documentation/filesystems/xfs-online-fsck-design.rst for more details.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>

diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
index 14826280d46e20dccfec1b746941b50c58aaad9d..5ff09c8c9439ed05c8cd340152ca417b0a8de0af 100644 (file)
--- a/libxfs/xfs_ialloc.c
+++ b/libxfs/xfs_ialloc.c
@@ -90,18 +90,28 @@ xfs_inobt_btrec_to_irec(
        irec->ir_free = be64_to_cpu(rec->inobt.ir_free);
 }
 
+/* Compute the freecount of an incore inode record. */
+uint8_t
+xfs_inobt_rec_freecount(
+       const struct xfs_inobt_rec_incore       *irec)
+{
+       uint64_t                                realfree = irec->ir_free;
+
+       if (xfs_inobt_issparse(irec->ir_holemask))
+               realfree &= xfs_inobt_irec_to_allocmask(irec);
+       return hweight64(realfree);
+}
+
 /* Simple checks for inode records. */
 xfs_failaddr_t
 xfs_inobt_check_irec(
-       struct xfs_btree_cur                    *cur,
+       struct xfs_perag                        *pag,
        const struct xfs_inobt_rec_incore       *irec)
 {
-       uint64_t                        realfree;
-
        /* Record has to be properly aligned within the AG. */
-       if (!xfs_verify_agino(cur->bc_ag.pag, irec->ir_startino))
+       if (!xfs_verify_agino(pag, irec->ir_startino))
                return __this_address;
-       if (!xfs_verify_agino(cur->bc_ag.pag,
+       if (!xfs_verify_agino(pag,
                                irec->ir_startino + XFS_INODES_PER_CHUNK - 1))
                return __this_address;
        if (irec->ir_count < XFS_INODES_PER_HOLEMASK_BIT ||
@@ -110,12 +120,7 @@ xfs_inobt_check_irec(
        if (irec->ir_freecount > XFS_INODES_PER_CHUNK)
                return __this_address;
 
-       /* if there are no holes, return the first available offset */
-       if (!xfs_inobt_issparse(irec->ir_holemask))
-               realfree = irec->ir_free;
-       else
-               realfree = irec->ir_free & xfs_inobt_irec_to_allocmask(irec);
-       if (hweight64(realfree) != irec->ir_freecount)
+       if (xfs_inobt_rec_freecount(irec) != irec->ir_freecount)
                return __this_address;
 
        return NULL;
@@ -159,7 +164,7 @@ xfs_inobt_get_rec(
                return error;
 
        xfs_inobt_btrec_to_irec(mp, rec, irec);
-       fa = xfs_inobt_check_irec(cur, irec);
+       fa = xfs_inobt_check_irec(cur->bc_ag.pag, irec);
        if (fa)
                return xfs_inobt_complain_bad_rec(cur, fa, irec);
 
@@ -2735,7 +2740,7 @@ xfs_ialloc_count_inodes_rec(
        xfs_failaddr_t                  fa;
 
        xfs_inobt_btrec_to_irec(cur->bc_mp, rec, &irec);
-       fa = xfs_inobt_check_irec(cur, &irec);
+       fa = xfs_inobt_check_irec(cur->bc_ag.pag, &irec);
        if (fa)
                return xfs_inobt_complain_bad_rec(cur, fa, &irec);
 

diff --git a/libxfs/xfs_ialloc.h b/libxfs/xfs_ialloc.h
index fe824bb04a091cf4781a4b595ff002f59b3a4f6c..f1412183bb44bb2578c5929b67d019cfb123d717 100644 (file)
--- a/libxfs/xfs_ialloc.h
+++ b/libxfs/xfs_ialloc.h
@@ -79,6 +79,7 @@ int xfs_inobt_lookup(struct xfs_btree_cur *cur, xfs_agino_t ino,
  */
 int xfs_inobt_get_rec(struct xfs_btree_cur *cur,
                xfs_inobt_rec_incore_t *rec, int *stat);
+uint8_t xfs_inobt_rec_freecount(const struct xfs_inobt_rec_incore *irec);
 
 /*
  * Inode chunk initialisation routine
@@ -93,7 +94,7 @@ union xfs_btree_rec;
 void xfs_inobt_btrec_to_irec(struct xfs_mount *mp,
                const union xfs_btree_rec *rec,
                struct xfs_inobt_rec_incore *irec);
-xfs_failaddr_t xfs_inobt_check_irec(struct xfs_btree_cur *cur,
+xfs_failaddr_t xfs_inobt_check_irec(struct xfs_perag *pag,
                const struct xfs_inobt_rec_incore *irec);
 int xfs_ialloc_has_inodes_at_extent(struct xfs_btree_cur *cur,
                xfs_agblock_t bno, xfs_extlen_t len,