]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
s390/ipl: Fix never less than zero warning
authorAlexander Gordeev <agordeev@linux.ibm.com>
Mon, 9 Dec 2024 16:43:48 +0000 (17:43 +0100)
committerAlexander Gordeev <agordeev@linux.ibm.com>
Wed, 11 Dec 2024 17:05:49 +0000 (18:05 +0100)
DEFINE_IPL_ATTR_STR_RW() macro produces "unsigned 'len' is never less
than zero." warning when sys_vmcmd_on_*_store() callbacks are defined.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412081614.5uel8F6W-lkp@intel.com/
Fixes: 247576bf624a ("s390/ipl: Do not accept z/VM CP diag X'008' cmds longer than max length")
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
arch/s390/kernel/ipl.c

index edbb52ce3f1ec23d8e464fce3fddee64d2327848..7d12a1305fc99f0777fadfc5e5b3c127d97fee79 100644 (file)
@@ -270,7 +270,7 @@ static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj,        \
        if (len >= sizeof(_value))                                      \
                return -E2BIG;                                          \
        len = strscpy(_value, buf, sizeof(_value));                     \
-       if (len < 0)                                                    \
+       if ((ssize_t)len < 0)                                           \
                return len;                                             \
        strim(_value);                                                  \
        return len;                                                     \