]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: spi-geni-qcom: Correct CS_TOGGLE bit in SPI_TRANS_CFG
authorVijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Tue, 25 Apr 2023 08:42:08 +0000 (14:12 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 8 May 2023 00:11:48 +0000 (09:11 +0900)
The CS_TOGGLE bit when set is supposed to instruct FW to
toggle CS line between words. The driver with intent of
disabling this behaviour has been unsetting BIT(0). This has
not caused any trouble so far because the original BIT(1)
is untouched and BIT(0) likely wasn't being used.

Correct this to prevent a potential future bug.

Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org
Fixes: 561de45f72bd ("spi: spi-geni-qcom: Add SPI driver support for GENI based QUP")
Reviewed-by: Douglas Anderson <dianders@chromium.org
Link: https://lore.kernel.org/r/1682412128-1913-1-git-send-email-quic_vnivarth@quicinc.com
Signed-off-by: Mark Brown <broonie@kernel.org
drivers/spi/spi-geni-qcom.c

index ba7be505ec4ef5594ea9e9d4ee6e24c247f10140..8a7d1c2eb4f02b16863b70232a2cba391ca95456 100644 (file)
@@ -35,7 +35,7 @@
 #define CS_DEMUX_OUTPUT_SEL    GENMASK(3, 0)
 
 #define SE_SPI_TRANS_CFG       0x25c
-#define CS_TOGGLE              BIT(0)
+#define CS_TOGGLE              BIT(1)
 
 #define SE_SPI_WORD_LEN                0x268
 #define WORD_LEN_MSK           GENMASK(9, 0)