put a _ before or_options_t elements that aren't configurable

it's fine with me if we change the current convention, but we should
actually decide to change it if we want to.

diff --git a/src/or/config.c b/src/or/config.c
index 1e7bd5844b2906c4f11b5776dff8ff039b3a44f6..fbbd9029f7ccf35718385f18d78574aa428108fe 100644 (file)
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -713,7 +713,7 @@ or_options_free(or_options_t *options)
     return;
 
   routerset_free(options->_ExcludeExitNodesUnion);
-  tor_free(options->BridgePassword_AuthDigest);
+  tor_free(options->_BridgePassword_AuthDigest);
   config_free(&options_format, options);
 }
 
@@ -1310,8 +1310,8 @@ options_act(or_options_t *old_options)
                "BridgePassword.");
       return -1;
     }
-    options->BridgePassword_AuthDigest = tor_malloc(DIGEST256_LEN);
-    crypto_digest256(options->BridgePassword_AuthDigest,
+    options->_BridgePassword_AuthDigest = tor_malloc(DIGEST256_LEN);
+    crypto_digest256(options->_BridgePassword_AuthDigest,
                      http_authenticator, strlen(http_authenticator),
                      DIGEST_SHA256);
     tor_free(http_authenticator);

diff --git a/src/or/directory.c b/src/or/directory.c
index 9bc58e5b36e8e641e5ccc201761679eea118c320..29cf10cea00cc564d00678cdcd254df595be1272 100644 (file)
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -3069,7 +3069,7 @@ directory_handle_command_get(dir_connection_t *conn, const char *headers,
   }
 
   if (options->BridgeAuthoritativeDir &&
-      options->BridgePassword_AuthDigest &&
+      options->_BridgePassword_AuthDigest &&
       connection_dir_is_encrypted(conn) &&
       !strcmp(url,"/tor/networkstatus-bridges")) {
     char *status;
@@ -3081,7 +3081,8 @@ directory_handle_command_get(dir_connection_t *conn, const char *headers,
 
     /* now make sure the password is there and right */
     if (!header ||
-        tor_memneq(digest, options->BridgePassword_AuthDigest, DIGEST256_LEN)) {
+        tor_memneq(digest,
+                   options->_BridgePassword_AuthDigest, DIGEST256_LEN)) {
       write_http_status_line(conn, 404, "Not found");
       tor_free(header);
       goto done;

diff --git a/src/or/or.h b/src/or/or.h
index 92592e5fa9262eb955d15c65e548c671d185d541..a4e8e4985bc30c243511685d97e2cb441cb6a228 100644 (file)
--- a/src/or/or.h
+++ b/src/or/or.h
@@ -2492,8 +2492,8 @@ typedef struct {
    * for bridge statuses -- but only if the requests use this password. */
   char *BridgePassword;
   /** If BridgePassword is set, this is a SHA256 digest of the basic http
-   * authenticator for it. */
-  char *BridgePassword_AuthDigest;
+   * authenticator for it. Used so we can do a time-independent comparison. */
+  char *_BridgePassword_AuthDigest;
 
   int UseBridges; /**< Boolean: should we start all circuits with a bridge? */
   config_line_t *Bridges; /**< List of bootstrap bridge addresses. */