]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86: think-lmi: Fix class device unregistration
authorKurt Borja <kuurtb@gmail.com>
Thu, 26 Jun 2025 01:17:36 +0000 (22:17 -0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 30 Jun 2025 09:12:16 +0000 (12:12 +0300)
Devices under the firmware_attributes_class do not have unique a dev_t.
Therefore, device_unregister() should be used instead of
device_destroy(), since the latter may match any device with a given
dev_t.

Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250625-dest-fix-v1-2-3a0f342312bb@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/think-lmi.c

index 00b1e7c79a3d1e95621701530ea5e11015414498..28ce475f6c3776f7f83ce4b78d6c6437b3663fd9 100644 (file)
@@ -1554,7 +1554,7 @@ static int tlmi_sysfs_init(void)
 fail_create_attr:
        tlmi_release_attr();
 fail_device_created:
-       device_destroy(&firmware_attributes_class, MKDEV(0, 0));
+       device_unregister(tlmi_priv.class_dev);
 fail_class_created:
        return ret;
 }
@@ -1781,7 +1781,7 @@ fail_clear_attr:
 static void tlmi_remove(struct wmi_device *wdev)
 {
        tlmi_release_attr();
-       device_destroy(&firmware_attributes_class, MKDEV(0, 0));
+       device_unregister(tlmi_priv.class_dev);
 }
 
 static int tlmi_probe(struct wmi_device *wdev, const void *context)