]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: usb-audio: Fix size validation in convert_chmap_v3()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 18 Aug 2025 09:59:45 +0000 (12:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:34:46 +0000 (16:34 +0200)
[ Upstream commit 89f0addeee3cb2dc49837599330ed9c4612f05b0 ]

The "p" pointer is void so sizeof(*p) is 1.  The intent was to check
sizeof(*cs_desc), which is 3, instead.

Fixes: ecfd41166b72 ("ALSA: usb-audio: Validate UAC3 cluster segment descriptors")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKL5kftC1qGt6lpv@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/stream.c

index 1cb52373e70f647cfd11fa4ec8a29711c192aa7e..db2c9bac00adca4d3624804f303a4a4a4b2d940a 100644 (file)
@@ -349,7 +349,7 @@ snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptor
                u16 cs_len;
                u8 cs_type;
 
-               if (len < sizeof(*p))
+               if (len < sizeof(*cs_desc))
                        break;
                cs_len = le16_to_cpu(cs_desc->wLength);
                if (len < cs_len)