]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bcachefs: Change bch2_fs_journal_stop() BUG_ON() to warning
authorKent Overstreet <kent.overstreet@linux.dev>
Fri, 28 Jun 2024 23:16:09 +0000 (19:16 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Fri, 28 Jun 2024 23:16:41 +0000 (19:16 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/journal.c

index 13669dd0e37561ca675676a9fe84b81b8a000a26..51c2fa09d951e128f3a7a8b74cb327b0a265e3f1 100644 (file)
@@ -1184,9 +1184,11 @@ void bch2_fs_journal_stop(struct journal *j)
        journal_quiesce(j);
        cancel_delayed_work_sync(&j->write_work);
 
-       BUG_ON(!bch2_journal_error(j) &&
-              test_bit(JOURNAL_replay_done, &j->flags) &&
-              j->last_empty_seq != journal_cur_seq(j));
+       WARN(!bch2_journal_error(j) &&
+            test_bit(JOURNAL_replay_done, &j->flags) &&
+            j->last_empty_seq != journal_cur_seq(j),
+            "journal shutdown error: cur seq %llu but last empty seq %llu",
+            journal_cur_seq(j), j->last_empty_seq);
 
        if (!bch2_journal_error(j))
                clear_bit(JOURNAL_running, &j->flags);