]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: scan: Use standard error checking pattern
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 25 Mar 2024 12:33:02 +0000 (14:33 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 4 Apr 2024 19:19:02 +0000 (21:19 +0200)
Check for an error and return it as it's the usual way to handle this.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/scan.c

index e64e1ec626b361fda6221b7a696c562d67a531ba..b9a33364e553bd126814765f21cd43ab8ae050d2 100644 (file)
@@ -1581,12 +1581,13 @@ int acpi_iommu_fwspec_init(struct device *dev, u32 id,
                           struct fwnode_handle *fwnode,
                           const struct iommu_ops *ops)
 {
-       int ret = iommu_fwspec_init(dev, fwnode, ops);
+       int ret;
 
-       if (!ret)
-               ret = iommu_fwspec_add_ids(dev, &id, 1);
+       ret = iommu_fwspec_init(dev, fwnode, ops);
+       if (ret)
+               return ret;
 
-       return ret;
+       return iommu_fwspec_add_ids(dev, &id, 1);
 }
 
 static inline const struct iommu_ops *acpi_iommu_fwspec_ops(struct device *dev)