]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
libiptc: fix fortify errors in debug code
authorMike Frysinger <vapier@gentoo.org>
Thu, 20 Aug 2015 11:12:59 +0000 (07:12 -0400)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 26 Aug 2015 19:08:05 +0000 (21:08 +0200)
When using open(O_CREAT), you must supply the mode bits, otherwise the
func will pull random garbage off the stack.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
libiptc/libiptc.c

index f0f78155ad2d0776e3b66575683d7bcafaa68ad3..9c07bb402bc52ab8276d3814c6c258a4a15e7de0 100644 (file)
@@ -1357,7 +1357,7 @@ retry:
 #ifdef IPTC_DEBUG2
        {
                int fd = open("/tmp/libiptc-so_get_entries.blob",
-                               O_CREAT|O_WRONLY);
+                               O_CREAT|O_WRONLY, 0644);
                if (fd >= 0) {
                        write(fd, h->entries, tmp);
                        close(fd);
@@ -2588,7 +2588,7 @@ TC_COMMIT(struct xtc_handle *handle)
 #ifdef IPTC_DEBUG2
        {
                int fd = open("/tmp/libiptc-so_set_replace.blob",
-                               O_CREAT|O_WRONLY);
+                               O_CREAT|O_WRONLY, 0644);
                if (fd >= 0) {
                        write(fd, repl, sizeof(*repl) + repl->size);
                        close(fd);
@@ -2664,7 +2664,7 @@ TC_COMMIT(struct xtc_handle *handle)
 #ifdef IPTC_DEBUG2
        {
                int fd = open("/tmp/libiptc-so_set_add_counters.blob",
-                               O_CREAT|O_WRONLY);
+                               O_CREAT|O_WRONLY, 0644);
                if (fd >= 0) {
                        write(fd, newcounters, counterlen);
                        close(fd);