]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
patman: Use a pager when outputting status
authorSimon Glass <sjg@chromium.org>
Tue, 29 Apr 2025 13:22:26 +0000 (07:22 -0600)
committerSimon Glass <sjg@chromium.org>
Tue, 27 May 2025 09:07:41 +0000 (10:07 +0100)
The pager makes it easier to review large number of comments. Add it
around the output.

Patman normally sends multiple concurrent requests to the patchwork
server, as this is faster. Provide an option to disable this.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/patman/status.py

index f5be51461e799f9c1f655f423c1b2e13d0bddd5d..dfc0f29faa4b978e5c03babba4cd9de59040c127 100644 (file)
@@ -382,22 +382,25 @@ def do_show_status(patches, series, branch, show_comments, col,
     new_rtag_list = [None] * count
     review_list = [None] * count
 
-    patch_for_commit, _, warnings = compare_with_series(series, compare)
-    for warn in warnings:
-        tout.do_output(tout.WARNING if warnings_on_stderr else tout.INFO, warn)
-
-    for seq, pw_patch in enumerate(patches):
-        compare[seq].patch = pw_patch
-
-    for i in range(count):
-        pat = patch_for_commit.get(i)
-        if pat:
-            patch_data = pat.patch.data
-            comment_data = pat.patch.comments
-            new_rtag_list[i], review_list[i] = process_reviews(
-                patch_data['content'], comment_data, series.commits[i].rtags)
-    num_to_add = _do_show_status(series, patch_for_commit, show_comments, new_rtag_list,
-                   review_list, col)
+    with terminal.pager():
+        patch_for_commit, _, warnings = compare_with_series(series, compare)
+        for warn in warnings:
+            tout.do_output(tout.WARNING if warnings_on_stderr else tout.INFO,
+                           warn)
+
+        for seq, pw_patch in enumerate(patches):
+            compare[seq].patch = pw_patch
+
+        for i in range(count):
+            pat = patch_for_commit.get(i)
+            if pat:
+                patch_data = pat.patch.data
+                comment_data = pat.patch.comments
+                new_rtag_list[i], review_list[i] = process_reviews(
+                    patch_data['content'], comment_data,
+                    series.commits[i].rtags)
+        num_to_add = _do_show_status(series, patch_for_commit, show_comments, new_rtag_list,
+                       review_list, col)
     return num_to_add, new_rtag_list, patches