http_proxy: only loop on 407 + close if we have credentials

... to fix the retry-loop.

Add test 718 to verify.

Reported-by: Daniel Kurečka
Fixes #6828
Closes #6850

diff --git a/lib/http_proxy.c b/lib/http_proxy.c
index 732fea7e347d5b387a260e531b6258216a225fa4..f403ffc0e093c9cec1732e4a05ac512d85867f41 100644 (file)
--- a/lib/http_proxy.c
+++ b/lib/http_proxy.c
@@ -358,7 +358,8 @@ static CURLcode CONNECT(struct Curl_easy *data,
           break;
         }
         else if(gotbytes <= 0) {
-          if(data->set.proxyauth && data->state.authproxy.avail) {
+          if(data->set.proxyauth && data->state.authproxy.avail &&
+             data->state.aptr.proxyuserpwd) {
             /* proxy auth was requested and there was proxy auth available,
                then deem this as "mere" proxy disconnect */
             conn->bits.proxy_connect_closed = TRUE;

diff --git a/tests/data/Makefile.inc b/tests/data/Makefile.inc
index 6ae2a249b4f8463dc421ee60e4cd8af975540f5c..d083baffa87e91c529468961d5866932dc93e67d 100644 (file)
--- a/tests/data/Makefile.inc
+++ b/tests/data/Makefile.inc
@@ -94,6 +94,7 @@ test670 test671 test672 test673 test674 test675 \
 \
 test700 test701 test702 test703 test704 test705 test706 test707 test708 \
 test709 test710 test711 test712 test713 test714 test715 test716 test717 \
+test718 \
 \
 test800 test801 test802 test803 test804 test805 test806 test807 test808 \
 test809 test810 test811 test812 test813 test814 test815 test816 test817 \

diff --git a/tests/data/test718 b/tests/data/test718
new file mode 100644 (file)
index 0000000..6ab6c5a
--- /dev/null
+++ b/tests/data/test718
@@ -0,0 +1,59 @@
+<testcase>
+<info>
+<keywords>
+HTTP
+HTTP GET
+HTTP CONNECT
+HTTP proxy
+proxytunnel
+HTTP proxy Digest auth
+</keywords>
+</info>
+
+# Server-side
+<reply>
+
+# this is returned first since we get no proxy-auth
+<connect>
+HTTP/1.1 407 Authorization Required to proxy me swsclose\r
+Proxy-Authenticate: Digest realm="weirdorealm", nonce="12345"\r
+</connect>
+
+<datacheck>
+HTTP/1.1 407 Authorization Required to proxy me swsclose\r
+Proxy-Authenticate: Digest realm="weirdorealm", nonce="12345"\r
+</datacheck>
+</reply>
+
+# Client-side
+<client>
+<server>
+http
+</server>
+<features>
+!SSPI
+crypto
+proxy
+</features>
+ <name>
+HTTP proxy CONNECT (no auth) with proxy returning 407 and closing
+ </name>
+ <command>
+http://test.remote.haxx.se.%TESTNUMBER:8990/path/%TESTNUMBER0002 --proxy http://%HOSTIP:%HTTPPORT --proxytunnel
+</command>
+</client>
+
+# Verify data after the test has been "shot"
+<verify>
+<protocol>
+CONNECT test.remote.haxx.se.%TESTNUMBER:8990 HTTP/1.1\r
+Host: test.remote.haxx.se.%TESTNUMBER:8990\r
+User-Agent: curl/%VERSION\r
+Proxy-Connection: Keep-Alive\r
+\r
+</protocol>
+<errorcode>
+56
+</errorcode>
+</verify>
+</testcase>