mfd: max77705: Setup the core driver as an interrupt controller

Current implementation describes only MFD's own topsys interrupts.
However, max77705 has a register which indicates interrupt source, i.e.
it acts as an interrupt controller. There's 4 interrupt sources in
max77705: topsys, charger, fuelgauge, usb type-c manager.

Setup max77705 MFD parent as an interrupt controller. Delete topsys
interrupts because currently unused.

Remove shared interrupt flag, because we're are an interrupt controller
now, and subdevices should request interrupts from us.

Fixes: c8d50f029748 ("mfd: Add new driver for MAX77705 PMIC")
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
Link: https://lore.kernel.org/r/20250909-max77705-fix_interrupt_handling-v3-1-233c5a1a20b5@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c
index 6b263bacb8c28d980e890777452db58be84d7338..62dbc63efa8d083a76718a8bd3f7cd0a13451727 100644 (file)
--- a/drivers/mfd/max77705.c
+++ b/drivers/mfd/max77705.c
@@ -61,21 +61,21 @@ static const struct regmap_config max77705_regmap_config = {
        .max_register = MAX77705_PMIC_REG_USBC_RESET,
 };
 
-static const struct regmap_irq max77705_topsys_irqs[] = {
-       { .mask = MAX77705_SYSTEM_IRQ_BSTEN_INT, },
-       { .mask = MAX77705_SYSTEM_IRQ_SYSUVLO_INT, },
-       { .mask = MAX77705_SYSTEM_IRQ_SYSOVLO_INT, },
-       { .mask = MAX77705_SYSTEM_IRQ_TSHDN_INT, },
-       { .mask = MAX77705_SYSTEM_IRQ_TM_INT, },
+static const struct regmap_irq max77705_irqs[] = {
+       { .mask = MAX77705_SRC_IRQ_CHG, },
+       { .mask = MAX77705_SRC_IRQ_TOP, },
+       { .mask = MAX77705_SRC_IRQ_FG, },
+       { .mask = MAX77705_SRC_IRQ_USBC, },
 };
 
-static const struct regmap_irq_chip max77705_topsys_irq_chip = {
-       .name           = "max77705-topsys",
-       .status_base    = MAX77705_PMIC_REG_SYSTEM_INT,
-       .mask_base      = MAX77705_PMIC_REG_SYSTEM_INT_MASK,
+static const struct regmap_irq_chip max77705_irq_chip = {
+       .name           = "max77705",
+       .status_base    = MAX77705_PMIC_REG_INTSRC,
+       .ack_base       = MAX77705_PMIC_REG_INTSRC,
+       .mask_base      = MAX77705_PMIC_REG_INTSRC_MASK,
        .num_regs       = 1,
-       .irqs           = max77705_topsys_irqs,
-       .num_irqs       = ARRAY_SIZE(max77705_topsys_irqs),
+       .irqs           = max77705_irqs,
+       .num_irqs       = ARRAY_SIZE(max77705_irqs),
 };
 
 static int max77705_i2c_probe(struct i2c_client *i2c)
@@ -110,19 +110,12 @@ static int max77705_i2c_probe(struct i2c_client *i2c)
 
        ret = devm_regmap_add_irq_chip(dev, max77705->regmap,
                                        i2c->irq,
-                                       IRQF_ONESHOT | IRQF_SHARED, 0,
-                                       &max77705_topsys_irq_chip,
+                                       IRQF_ONESHOT, 0,
+                                       &max77705_irq_chip,
                                        &irq_data);
        if (ret)
                return dev_err_probe(dev, ret, "Failed to add IRQ chip\n");
 
-       /* Unmask interrupts from all blocks in interrupt source register */
-       ret = regmap_update_bits(max77705->regmap,
-                                MAX77705_PMIC_REG_INTSRC_MASK,
-                                MAX77705_SRC_IRQ_ALL, (unsigned int)~MAX77705_SRC_IRQ_ALL);
-       if (ret < 0)
-               return dev_err_probe(dev, ret, "Could not unmask interrupts in INTSRC\n");
-
        domain = regmap_irq_get_domain(irq_data);
 
        ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,