]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: m_can: hrtimer_callback(): rename to m_can_polling_timer()
authorMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 7 Aug 2025 18:14:55 +0000 (20:14 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 17 Oct 2025 13:16:51 +0000 (15:16 +0200)
The original use of struct m_can_classdev::hrtimer was to support polling
for devices without IRQ, with the timer function called hrtimer_callback().

Commit 07f25091ca02 ("can: m_can: Implement receive coalescing") uses the
hrtimer for software-supported IRQ coalescence, with the timer function
called m_can_coalescing_timer().

To improve the readability of the driver, rename hrtimer_callback() to
m_can_polling_timer(), which better describes the functionality.

Link: https://patch.msgid.link/20251008-m_can-cleanups-v1-2-1784a18eaa84@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c

index 9f4002f3481e586442bfa49cd1086e52caa18858..110cfd54b66950aa6c2828dc99b6c438bf1032e8 100644 (file)
@@ -2058,7 +2058,7 @@ static netdev_tx_t m_can_start_xmit(struct sk_buff *skb,
        return ret;
 }
 
-static enum hrtimer_restart hrtimer_callback(struct hrtimer *timer)
+static enum hrtimer_restart m_can_polling_timer(struct hrtimer *timer)
 {
        struct m_can_classdev *cdev = container_of(timer, struct
                                                   m_can_classdev, hrtimer);
@@ -2545,7 +2545,7 @@ int m_can_class_register(struct m_can_classdev *cdev)
 
        if (!cdev->net->irq) {
                dev_dbg(cdev->dev, "Polling enabled, initialize hrtimer");
-               hrtimer_setup(&cdev->hrtimer, &hrtimer_callback, CLOCK_MONOTONIC,
+               hrtimer_setup(&cdev->hrtimer, m_can_polling_timer, CLOCK_MONOTONIC,
                              HRTIMER_MODE_REL_PINNED);
        } else {
                hrtimer_setup(&cdev->hrtimer, m_can_coalescing_timer, CLOCK_MONOTONIC,