Bug 1217882: ensure SQL querys from FlagTypeComment are valid

when $types is empty the SQL query is invalid

diff --git a/extensions/FlagTypeComment/Extension.pm b/extensions/FlagTypeComment/Extension.pm
index e5892fcbe90043dbdb193c9a701ce9963f853ed5..4a7e1bb117076abdded252adf9f51d9bb96538aa 100644 (file)
--- a/extensions/FlagTypeComment/Extension.pm
+++ b/extensions/FlagTypeComment/Extension.pm
@@ -72,7 +72,7 @@ sub _set_ftc_states {
   my $dbh = Bugzilla->dbh;
 
   my $ftc_flags;
-  my $db_result;
+  my $db_result = [];
   if ($file =~ /^admin\//) {
 
     # admin
@@ -121,11 +121,13 @@ sub _set_ftc_states {
 
     my $types = join(',', map { $_->id } @$flag_types);
     my $states = "'" . join("','", FLAGTYPE_COMMENT_STATES) . "'";
-    $db_result = $dbh->selectall_arrayref(
-      "SELECT type_id AS flagtype, on_status AS state, comment AS text
-               FROM flagtype_comments
-              WHERE type_id IN ($types) AND on_status IN ($states)", {Slice => {}}
-    );
+    if ($types) {
+      $db_result = $dbh->selectall_arrayref(
+        "SELECT type_id AS flagtype, on_status AS state, comment AS text
+                 FROM flagtype_comments
+                WHERE type_id IN ($types) AND on_status IN ($states)", {Slice => {}}
+      );
+    }
   }
 
   foreach my $row (@$db_result) {