strerror_r on MacOS returns int despite _GNU_SOURCE being defined

diff --git a/configure.ac b/configure.ac
index efa0adfa7884a9782695652f711b08c050234441..2359358f07162b8d69bcdc319fa17bd8b2b6ff01 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -39,6 +39,7 @@ LT_INIT([disable-static dlopen])
 
 PDNS_CHECK_OS
 PTHREAD_SET_NAME
+AC_FUNC_STRERROR_R
 
 PDNS_WITH_LUA([mandatory])
 PDNS_CHECK_LUA_HPP

diff --git a/pdns/dnsdistdist/configure.ac b/pdns/dnsdistdist/configure.ac
index b5757f088d5a14654ef509c43abc67037f47335b..dd04e1042d6d24446d4c670d61be342476fea8bd 100644 (file)
--- a/pdns/dnsdistdist/configure.ac
+++ b/pdns/dnsdistdist/configure.ac
@@ -32,6 +32,7 @@ PTHREAD_SET_NAME
 PDNS_CHECK_NETWORK_LIBS
 PDNS_CHECK_PTHREAD_NP
 PDNS_CHECK_SECURE_MEMSET
+AC_FUNC_STRERROR_R
 
 BOOST_REQUIRE([1.42])
 

diff --git a/pdns/misc.cc b/pdns/misc.cc
index 90ec60ade31dd3b8fc068910efac48d950a658b7..486511d46e141882531919bb98b2927b61fa7eb4 100644 (file)
--- a/pdns/misc.cc
+++ b/pdns/misc.cc
@@ -205,7 +205,7 @@ auto pdns::getMessageFromErrno(const int errnum) -> std::string
   errMsgData.resize(errLen);
 
   const char* errMsg = nullptr;
-#ifdef _GNU_SOURCE
+#ifdef STRERROR_R_CHAR_P
   errMsg = strerror_r(errnum, errMsgData.data(), errMsgData.length());
 #else
   // This can fail, and when it does, it sets errno. We ignore that and

diff --git a/pdns/recursordist/configure.ac b/pdns/recursordist/configure.ac
index c8bf30decd3532b72393aa9d0e98c4bbf9c7baef..b4fe07ee7e30f8f52953ffeb92972b9269f2d5c2 100644 (file)
--- a/pdns/recursordist/configure.ac
+++ b/pdns/recursordist/configure.ac
@@ -40,6 +40,7 @@ LT_INIT()
 PDNS_CHECK_OS
 PDNS_CHECK_NETWORK_LIBS
 PTHREAD_SET_NAME
+AC_FUNC_STRERROR_R
 
 PDNS_CHECK_CLOCK_GETTIME
 
@@ -98,7 +99,7 @@ PDNS_ENABLE_DNS_OVER_TLS
 AS_IF([test "x$enable_dns_over_tls" != "xno"], [
   PDNS_WITH_LIBSSL
   # not runtime selectable at the moment
-  # PDNS_WITH_GNUTLS 
+  # PDNS_WITH_GNUTLS
 
   AS_IF([test "x$HAVE_LIBSSL" != "x1"], [
     AC_MSG_ERROR([DNS over TLS support requested but no OpenSSL available])