]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: client: transaction: Annotate sub-parts of smtp_client_transaction_send_mor...
authorStephan Bosch <stephan.bosch@dovecot.fi>
Fri, 28 Sep 2018 11:17:30 +0000 (13:17 +0200)
committerVille Savolainen <ville.savolainen@dovecot.fi>
Tue, 12 Feb 2019 13:40:48 +0000 (15:40 +0200)
src/lib-smtp/smtp-client-transaction.c

index aadcbdfece544d9f89e6b55bc2743ee92d8ac9e0..977bcf36854e3b87b48be91496b2af5e4e992aa2 100644 (file)
@@ -736,11 +736,13 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
 
        timeout_remove(&trans->to_send);
 
+       /* Check whether we already failed */
        if (trans->failure != NULL) {
                smtp_client_transaction_fail_reply(trans, trans->failure);
                return;
        }
 
+       /* Make sure transaction is started */
        if (trans->state == SMTP_CLIENT_TRANSACTION_STATE_NEW) {
                enum smtp_client_transaction_state state;
                struct smtp_client_transaction *tmp_trans = trans;
@@ -756,6 +758,7 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
        if (trans->state <= SMTP_CLIENT_TRANSACTION_STATE_PENDING)
                return;
 
+       /* RCPT */
        rcpt = array_get_modifiable(&trans->rcpts_pending, &count);
        if (trans->rcpts_next_send_idx < count) {
                unsigned int i;
@@ -782,6 +785,7 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
                }
        }
 
+       /* DATA */
        if (trans->data_input != NULL)
                smtp_client_transaction_send_data(trans);
 }