rtc: bbnsm: add remove hook

Without remove hook to clear wake irq, there will be kernel dump when
doing module test.
"bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized"

Add remove hook to clear wake irq and set wakeup to false.

Fixes: eb7b85853c38 ("rtc: bbnsm: Add the bbnsm rtc support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20241111071130.1099978-1-peng.fan@oss.nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c
index acbfbeb8b0700708464867d3395f890dd77271ed..fa3b0328c7a255ff8a902a58d61a4b0e59eac493 100644 (file)
--- a/drivers/rtc/rtc-nxp-bbnsm.c
+++ b/drivers/rtc/rtc-nxp-bbnsm.c
@@ -197,13 +197,28 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
        if (ret) {
                dev_err(&pdev->dev, "failed to request irq %d: %d\n",
                        bbnsm->irq, ret);
-               return ret;
+               goto err;
        }
 
        bbnsm->rtc->ops = &bbnsm_rtc_ops;
        bbnsm->rtc->range_max = U32_MAX;
 
-       return devm_rtc_register_device(bbnsm->rtc);
+       ret = devm_rtc_register_device(bbnsm->rtc);
+       if (ret)
+               goto err;
+
+       return 0;
+
+err:
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
+       return ret;
+}
+
+static void bbnsm_rtc_remove(struct platform_device *pdev)
+{
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
 }
 
 static const struct of_device_id bbnsm_dt_ids[] = {
@@ -218,6 +233,7 @@ static struct platform_driver bbnsm_rtc_driver = {
                .of_match_table = bbnsm_dt_ids,
        },
        .probe = bbnsm_rtc_probe,
+       .remove = bbnsm_rtc_remove,
 };
 module_platform_driver(bbnsm_rtc_driver);