[BUG] stats: admin commands must check the proxy state

As reported by Bryan Talbot, enabling and disabling a server in a disabled
proxy causes a segfault.

Changing the weight can also cause a similar segfault.

diff --git a/src/dumpstats.c b/src/dumpstats.c
index 980b28485aabb575577ba94156a4883ff98f7d90..081e4cd3714c0921fe06a95f99b0abfb406330f1 100644 (file)
--- a/src/dumpstats.c
+++ b/src/dumpstats.c
@@ -639,6 +639,12 @@ int stats_sock_parse_request(struct stream_interface *si, char *line)
                                return 1;
                        }
 
+                       if (px->state == PR_STSTOPPED) {
+                               s->data_ctx.cli.msg = "Proxy is disabled.\n";
+                               si->st0 = STAT_CLI_PRINT;
+                               return 1;
+                       }
+
                        /* if the weight is terminated with '%', it is set relative to
                         * the initial weight, otherwise it is absolute.
                         */
@@ -749,6 +755,12 @@ int stats_sock_parse_request(struct stream_interface *si, char *line)
                                return 1;
                        }
 
+                       if (px->state == PR_STSTOPPED) {
+                               s->data_ctx.cli.msg = "Proxy is disabled.\n";
+                               si->st0 = STAT_CLI_PRINT;
+                               return 1;
+                       }
+
                        if (sv->state & SRV_MAINTAIN) {
                                /* The server is really in maintenance, we can change the server state */
                                if (sv->tracked) {
@@ -804,6 +816,12 @@ int stats_sock_parse_request(struct stream_interface *si, char *line)
                                return 1;
                        }
 
+                       if (px->state == PR_STSTOPPED) {
+                               s->data_ctx.cli.msg = "Proxy is disabled.\n";
+                               si->st0 = STAT_CLI_PRINT;
+                               return 1;
+                       }
+
                        if (! (sv->state & SRV_MAINTAIN)) {
                                /* Not already in maintenance, we can change the server state */
                                sv->state |= SRV_MAINTAIN;