]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
3.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jul 2015 01:34:41 +0000 (18:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jul 2015 01:34:41 +0000 (18:34 -0700)
added patches:
cpuidle-menu-return-1-if-there-are-no-suitable-states.patch

queue-3.14/cpuidle-menu-return-1-if-there-are-no-suitable-states.patch [new file with mode: 0644]
queue-3.14/series

diff --git a/queue-3.14/cpuidle-menu-return-1-if-there-are-no-suitable-states.patch b/queue-3.14/cpuidle-menu-return-1-if-there-are-no-suitable-states.patch
new file mode 100644 (file)
index 0000000..2052df3
--- /dev/null
@@ -0,0 +1,53 @@
+From 3836785a1bdcd6706c68ad46bf53adc0b057b310 Mon Sep 17 00:00:00 2001
+From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
+Date: Thu, 1 May 2014 00:14:04 +0200
+Subject: cpuidle / menu: Return (-1) if there are no suitable states
+
+From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
+
+commit 3836785a1bdcd6706c68ad46bf53adc0b057b310 upstream.
+
+If there is a PM QoS latency limit and all of the sufficiently shallow
+C-states are disabled, the cpuidle menu governor returns 0 which on
+some systems is CPUIDLE_DRIVER_STATE_START and shouldn't be returned
+if that C-state has been disabled.
+
+Fix the issue by modifying the menu governor to return (-1) in such
+situations.
+
+Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
+[shilpab: Backport to 3.10.y
+ - adjust context
+ - add a check if 'next_state' is less than 0 in 'cpuidle_idle_call()',
+   this ensures that we exit 'cpuidle_idle_call()' if governor->select()
+   returns  negative value]
+Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/cpuidle/cpuidle.c        |    3 +++
+ drivers/cpuidle/governors/menu.c |    2 +-
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+--- a/drivers/cpuidle/cpuidle.c
++++ b/drivers/cpuidle/cpuidle.c
+@@ -131,6 +131,9 @@ int cpuidle_idle_call(void)
+       /* ask the governor for the next state */
+       next_state = cpuidle_curr_governor->select(drv, dev);
++      if (next_state < 0)
++              return -EBUSY;
++
+       if (need_resched()) {
+               dev->last_residency = 0;
+               /* give the governor an opportunity to reflect on the outcome */
+--- a/drivers/cpuidle/governors/menu.c
++++ b/drivers/cpuidle/governors/menu.c
+@@ -297,7 +297,7 @@ static int menu_select(struct cpuidle_dr
+               data->needs_update = 0;
+       }
+-      data->last_state_idx = 0;
++      data->last_state_idx = CPUIDLE_DRIVER_STATE_START - 1;
+       data->exit_us = 0;
+       /* Special case when user has set very strict latency requirement */
index 3340f375f7ef83102185d5b0ee215a8853ca260c..b5daa62653acbac54be224406602825a280d981a 100644 (file)
@@ -8,3 +8,4 @@ arc-add-compiler-barrier-to-llsc-based-cmpxchg.patch
 arm64-do-not-attempt-to-use-init_mm-in-reset_context.patch
 arm64-mm-fix-freeing-of-the-wrong-memmap-entries-with-sparsemem_vmemmap.patch
 arm64-vdso-work-around-broken-elf-toolchains-in-makefile.patch
+cpuidle-menu-return-1-if-there-are-no-suitable-states.patch