]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: fix cleanup path after mhi init
authorRaj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Thu, 3 Apr 2025 10:04:29 +0000 (15:34 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Sat, 12 Apr 2025 04:19:28 +0000 (21:19 -0700)
Currently, the 'err_pci_msi_free' label is misplaced, causing the cleanup
sequence to be incorrect. Fix this by moving the 'err_pci_msi_free' label
to the correct position after 'err_irq_affinity_cleanup'.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1

Fixes: a3012f206d07 ("wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector")
Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250403-ath12k-cleanup-v1-1-ad8f67b0e9cf@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/pci.c

index 7f1bb150f326b317157f6721d990d61a27f38d6a..fcb9c40b227b7baaf49f6a590c495f47ca8d2f55 100644 (file)
@@ -1706,12 +1706,12 @@ err_hal_srng_deinit:
 err_mhi_unregister:
        ath12k_mhi_unregister(ab_pci);
 
-err_pci_msi_free:
-       ath12k_pci_msi_free(ab_pci);
-
 err_irq_affinity_cleanup:
        ath12k_pci_set_irq_affinity_hint(ab_pci, NULL);
 
+err_pci_msi_free:
+       ath12k_pci_msi_free(ab_pci);
+
 err_pci_free_region:
        ath12k_pci_free_region(ab_pci);