]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
tests: Fix trace-cmd recording with python3
authorJohannes Berg <johannes.berg@intel.com>
Fri, 12 Apr 2019 11:20:19 +0000 (13:20 +0200)
committerJouni Malinen <j@w1.fi>
Fri, 12 Apr 2019 17:43:33 +0000 (20:43 +0300)
The change to python3 broke trace-cmd recording, two
strings need to be bytes instead. Fix that.

Also add a flush() that seems to be needed now.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
tests/hwsim/run-tests.py

index 717d0dfa63e1ae20a63a5d6ecc14082e34e53ccc..940448180a380fcc476059507ad43b0977f9c68a 100755 (executable)
@@ -139,7 +139,7 @@ class DataCollector(object):
                                                stderr=open('/dev/null', 'w'),
                                                cwd=self._logdir)
             l = self._trace_cmd.stdout.read(7)
-            while self._trace_cmd.poll() is None and 'STARTED' not in l:
+            while self._trace_cmd.poll() is None and b'STARTED' not in l:
                 l += self._trace_cmd.stdout.read(1)
             res = self._trace_cmd.returncode
             if res:
@@ -157,7 +157,8 @@ class DataCollector(object):
                 sys.exit(1)
     def __exit__(self, type, value, traceback):
         if self._tracing:
-            self._trace_cmd.stdin.write('DONE\n')
+            self._trace_cmd.stdin.write(b'DONE\n')
+            self._trace_cmd.stdin.flush()
             self._trace_cmd.wait()
         if self._dmesg:
             output = os.path.join(self._logdir, '%s.dmesg' % (self._testname, ))