]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/mediatek: mtk_dpi: Use switch in mtk_dpi_config_color_format()
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Wed, 9 Apr 2025 13:13:02 +0000 (15:13 +0200)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Sun, 27 Apr 2025 01:26:56 +0000 (01:26 +0000)
In preparation for adding support for an additional color format,
convert the format conditional in mtk_dpi_config_color_format()
to a switch.
This also makes the concept of RGB being the default color format
a little more human readable.

This commit brings no functional differences.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250409131306.108635-2-angelogioacchino.delregno@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_dpi.c

index 0fd13e6dd3f16ed5a9c6e8a021eb9be1cb6e8d1b..d735398e97f81c3873882b8617da899c05edd9be 100644 (file)
@@ -452,7 +452,8 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
 {
        mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
 
-       if (format == MTK_DPI_COLOR_FORMAT_YCBCR_422) {
+       switch (format) {
+       case MTK_DPI_COLOR_FORMAT_YCBCR_422:
                mtk_dpi_config_yuv422_enable(dpi, true);
                mtk_dpi_config_csc_enable(dpi, true);
 
@@ -463,11 +464,14 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
                mtk_dpi_mask(dpi, DPI_MATRIX_SET, dpi->mode.hdisplay <= 720 ?
                             MATRIX_SEL_RGB_TO_BT601 : MATRIX_SEL_RGB_TO_JPEG,
                             INT_MATRIX_SEL_MASK);
-       } else {
+               break;
+       default:
+       case MTK_DPI_COLOR_FORMAT_RGB:
                mtk_dpi_config_yuv422_enable(dpi, false);
                mtk_dpi_config_csc_enable(dpi, false);
                if (dpi->conf->swap_input_support)
                        mtk_dpi_config_swap_input(dpi, false);
+               break;
        }
 }