Report tuple address in data-corruption error message

Most data-corruption reports mention the location of the problem, but
this one failed to.  Add it.

Backpatch all the way back.  In 12 and older, also assign the
ERRCODE_DATA_CORRUPTED error code as was done in commit fd6ec93bf890 for
13 and later.

Discussion: https://postgr.es/m/202108191637.oqyzrdtnheir@alvherre.pgsql

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index d1e0d53e6e42c622e6a68a401b37bb8edd0d1b4b..5deceeb86e9b634d141c4f5ede83b920246e9c64 100644 (file)
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -422,7 +422,11 @@ tuple_lock_retry:
                                        if (TransactionIdIsValid(SnapshotDirty.xmin))
                                                ereport(ERROR,
                                                                (errcode(ERRCODE_DATA_CORRUPTED),
-                                                                errmsg_internal("t_xmin is uncommitted in tuple to be updated")));
+                                                                errmsg_internal("t_xmin %u is uncommitted in tuple (%u,%u) to be updated in table \"%s\"",
+                                                                                                SnapshotDirty.xmin,
+                                                                                                ItemPointerGetBlockNumber(&tuple->t_self),
+                                                                                                ItemPointerGetOffsetNumber(&tuple->t_self),
+                                                                                                RelationGetRelationName(relation))));
 
                                        /*
                                         * If tuple is being updated by other transaction then we