]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Annotate default for guc_log_level param
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 13 Jun 2025 20:00:38 +0000 (13:00 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Tue, 17 Jun 2025 19:21:55 +0000 (12:21 -0700)
Reword the parameter description so it's clear what's the default and
what are the verbose levels.

Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://lore.kernel.org/r/20250613-guc-log-level-v2-2-cb84a63e49fe@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_module.c

index da6793c2f991e429421a3d0a8cd28ba41f39d306..e332f3142435e2efc279b1ef44346fadbcfce7c4 100644 (file)
 #include "xe_observation.h"
 #include "xe_sched_job.h"
 
+#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
+#define DEFAULT_GUC_LOG_LEVEL  3
+#else
+#define DEFAULT_GUC_LOG_LEVEL  1
+#endif
+
 struct xe_modparam xe_modparam = {
        .probe_display = true,
-       .guc_log_level = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? 3 : 1,
+       .guc_log_level = DEFAULT_GUC_LOG_LEVEL,
        .force_probe = CONFIG_DRM_XE_FORCE_PROBE,
        .wedged_mode = 1,
        .svm_notifier_size = 512,
@@ -40,7 +46,8 @@ module_param_named(vram_bar_size, xe_modparam.force_vram_bar_size, int, 0600);
 MODULE_PARM_DESC(vram_bar_size, "Set the vram bar size (in MiB) - <0=disable-resize, 0=max-needed-size[default], >0=force-size");
 
 module_param_named(guc_log_level, xe_modparam.guc_log_level, int, 0600);
-MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1..5=enable with verbosity min..max)");
+MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1=normal, 2..5=verbose-levels "
+                "[default=" __stringify(DEFAULT_GUC_LOG_LEVEL) "])");
 
 module_param_named_unsafe(guc_firmware_path, xe_modparam.guc_firmware_path, charp, 0400);
 MODULE_PARM_DESC(guc_firmware_path,