]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 May 2017 07:43:12 +0000 (09:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 May 2017 07:43:12 +0000 (09:43 +0200)
added patches:
9p-fix-a-potential-acl-leak.patch

queue-4.4/9p-fix-a-potential-acl-leak.patch [new file with mode: 0644]

diff --git a/queue-4.4/9p-fix-a-potential-acl-leak.patch b/queue-4.4/9p-fix-a-potential-acl-leak.patch
new file mode 100644 (file)
index 0000000..b95bc7c
--- /dev/null
@@ -0,0 +1,48 @@
+From b5c66bab72a6a65edb15beb60b90d3cb84c5763b Mon Sep 17 00:00:00 2001
+From: Cong Wang <xiyou.wangcong@gmail.com>
+Date: Wed, 22 Feb 2017 15:40:53 -0800
+Subject: 9p: fix a potential acl leak
+
+From: Cong Wang <xiyou.wangcong@gmail.com>
+
+commit b5c66bab72a6a65edb15beb60b90d3cb84c5763b upstream.
+
+posix_acl_update_mode() could possibly clear 'acl', if so we leak the
+memory pointed by 'acl'.  Save this pointer before calling
+posix_acl_update_mode() and release the memory if 'acl' really gets
+cleared.
+
+Link: http://lkml.kernel.org/r/1486678332-2430-1-git-send-email-xiyou.wangcong@gmail.com
+Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
+Reported-by: Mark Salyzyn <salyzyn@android.com>
+Reviewed-by: Jan Kara <jack@suse.cz>
+Reviewed-by: Greg Kurz <groug@kaod.org>
+Cc: Eric Van Hensbergen <ericvh@gmail.com>
+Cc: Ron Minnich <rminnich@sandia.gov>
+Cc: Latchesar Ionkov <lucho@ionkov.net>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ fs/9p/acl.c |    2 ++
+ 1 file changed, 2 insertions(+)
+
+--- a/fs/9p/acl.c
++++ b/fs/9p/acl.c
+@@ -283,6 +283,7 @@ static int v9fs_xattr_set_acl(const stru
+       case ACL_TYPE_ACCESS:
+               if (acl) {
+                       struct iattr iattr;
++                      struct posix_acl *old_acl = acl;
+                       retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);
+                       if (retval)
+@@ -293,6 +294,7 @@ static int v9fs_xattr_set_acl(const stru
+                                * by the mode bits. So don't
+                                * update ACL.
+                                */
++                              posix_acl_release(old_acl);
+                               value = NULL;
+                               size = 0;
+                       }