]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
APPS/cmp: Simplify read_write_req_resp() - 'req' arg must not be NULL anyway
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Tue, 7 Dec 2021 17:02:19 +0000 (18:02 +0100)
committerDr. David von Oheimb <dev@ddvo.net>
Mon, 13 Dec 2021 08:52:02 +0000 (09:52 +0100)
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17251)

apps/cmp.c

index e35626ebb2faad9160ada6698a482cbec003edc2..d6ab2a249b810512b529b8d7926c664b3f3a761f 100644 (file)
@@ -789,8 +789,7 @@ static OSSL_CMP_MSG *read_write_req_resp(OSSL_CMP_CTX *ctx,
     OSSL_CMP_PKIHEADER *hdr;
     const char *prev_opt_rspin = opt_rspin;
 
-    if (req != NULL && opt_reqout != NULL
-            && !write_PKIMESSAGE(req, &opt_reqout))
+    if (opt_reqout != NULL && !write_PKIMESSAGE(req, &opt_reqout))
         goto err;
     if (opt_reqin != NULL && opt_rspin == NULL) {
         if ((req_new = read_PKIMESSAGE(&opt_reqin)) == NULL)