]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ti: am65-cpsw-nuss: Use syscon_regmap_lookup_by_phandle_args
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 12 Jan 2025 13:32:44 +0000 (14:32 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 15 Jan 2025 02:04:07 +0000 (18:04 -0800)
Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
syscon_regmap_lookup_by_phandle() combined with getting the syscon
argument.  Except simpler code this annotates within one line that given
phandle has arguments, so grepping for code would be easier.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250112-syscon-phandle-args-net-v1-2-3423889935f7@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index 0fb5f92f28f6753d2eea3854aa6d855c66c6c39f..3fd8fc3121dc0485737e3919a315fe413d9773e6 100644 (file)
@@ -2569,20 +2569,15 @@ static int am65_cpsw_am654_get_efuse_macid(struct device_node *of_node,
 {
        u32 mac_lo, mac_hi, offset;
        struct regmap *syscon;
-       int ret;
 
-       syscon = syscon_regmap_lookup_by_phandle(of_node, "ti,syscon-efuse");
+       syscon = syscon_regmap_lookup_by_phandle_args(of_node, "ti,syscon-efuse",
+                                                     1, &offset);
        if (IS_ERR(syscon)) {
                if (PTR_ERR(syscon) == -ENODEV)
                        return 0;
                return PTR_ERR(syscon);
        }
 
-       ret = of_property_read_u32_index(of_node, "ti,syscon-efuse", 1,
-                                        &offset);
-       if (ret)
-               return ret;
-
        regmap_read(syscon, offset, &mac_lo);
        regmap_read(syscon, offset + 4, &mac_hi);