stats: Fail to load with empty metric filters

diff --git a/src/stats/stats-settings.c b/src/stats/stats-settings.c
index b9ae1decca10d4c3d83b88aa2872106c50e82a5c..b7879332cf359e1fb30e2c27ef2895529e8ee4b1 100644 (file)
--- a/src/stats/stats-settings.c
+++ b/src/stats/stats-settings.c
@@ -481,6 +481,12 @@ static bool stats_metric_settings_check(void *_set, pool_t pool, const char **er
                return FALSE;
        }
 
+       if (set->filter[0] == '\0') {
+               *error_r = t_strdup_printf("metric %s { filter } is empty - "
+                                          "will not match anything", set->metric_name);
+               return FALSE;
+       }
+
        set->parsed_filter = event_filter_create_fragment(pool);
        if (event_filter_parse(set->filter, set->parsed_filter, error_r) < 0)
                return FALSE;