iommu/arm-smmu: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230321084125.337021-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
index f4a36533ae478c831dcb459ab830157e9222bfed..b30a4bd7c79db4bd95f5a63829ae5235e86d70de 100644 (file)
--- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
@@ -2211,7 +2211,7 @@ static void arm_smmu_device_shutdown(struct platform_device *pdev)
        clk_bulk_unprepare(smmu->num_clks, smmu->clks);
 }
 
-static int arm_smmu_device_remove(struct platform_device *pdev)
+static void arm_smmu_device_remove(struct platform_device *pdev)
 {
        struct arm_smmu_device *smmu = platform_get_drvdata(pdev);
 
@@ -2219,8 +2219,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
        iommu_device_sysfs_remove(&smmu->iommu);
 
        arm_smmu_device_shutdown(pdev);
-
-       return 0;
 }
 
 static int __maybe_unused arm_smmu_runtime_resume(struct device *dev)
@@ -2296,7 +2294,7 @@ static struct platform_driver arm_smmu_driver = {
                .suppress_bind_attrs    = true,
        },
        .probe  = arm_smmu_device_probe,
-       .remove = arm_smmu_device_remove,
+       .remove_new = arm_smmu_device_remove,
        .shutdown = arm_smmu_device_shutdown,
 };
 module_platform_driver(arm_smmu_driver);

diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index c8b70f476cd83f6f4c747a95bbaa059824736c1b..a503ed758ec3029ed75c74ab7ef8c55e846991c1 100644 (file)
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -682,7 +682,7 @@ static int qcom_iommu_ctx_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int qcom_iommu_ctx_remove(struct platform_device *pdev)
+static void qcom_iommu_ctx_remove(struct platform_device *pdev)
 {
        struct qcom_iommu_dev *qcom_iommu = dev_get_drvdata(pdev->dev.parent);
        struct qcom_iommu_ctx *ctx = platform_get_drvdata(pdev);
@@ -690,8 +690,6 @@ static int qcom_iommu_ctx_remove(struct platform_device *pdev)
        platform_set_drvdata(pdev, NULL);
 
        qcom_iommu->ctxs[ctx->asid - 1] = NULL;
-
-       return 0;
 }
 
 static const struct of_device_id ctx_of_match[] = {
@@ -706,7 +704,7 @@ static struct platform_driver qcom_iommu_ctx_driver = {
                .of_match_table = ctx_of_match,
        },
        .probe  = qcom_iommu_ctx_probe,
-       .remove = qcom_iommu_ctx_remove,
+       .remove_new = qcom_iommu_ctx_remove,
 };
 
 static bool qcom_iommu_has_secure_context(struct qcom_iommu_dev *qcom_iommu)
@@ -824,7 +822,7 @@ err_pm_disable:
        return ret;
 }
 
-static int qcom_iommu_device_remove(struct platform_device *pdev)
+static void qcom_iommu_device_remove(struct platform_device *pdev)
 {
        struct qcom_iommu_dev *qcom_iommu = platform_get_drvdata(pdev);
 
@@ -832,8 +830,6 @@ static int qcom_iommu_device_remove(struct platform_device *pdev)
        platform_set_drvdata(pdev, NULL);
        iommu_device_sysfs_remove(&qcom_iommu->iommu);
        iommu_device_unregister(&qcom_iommu->iommu);
-
-       return 0;
 }
 
 static int __maybe_unused qcom_iommu_resume(struct device *dev)
@@ -870,7 +866,7 @@ static struct platform_driver qcom_iommu_driver = {
                .pm             = &qcom_iommu_pm_ops,
        },
        .probe  = qcom_iommu_device_probe,
-       .remove = qcom_iommu_device_remove,
+       .remove_new = qcom_iommu_device_remove,
 };
 
 static int __init qcom_iommu_init(void)