]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/gt: remove GRAPHICS_VER == 10
authorLucas De Marchi <lucas.demarchi@intel.com>
Wed, 28 Jul 2021 22:03:26 +0000 (15:03 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 29 Jul 2021 17:06:10 +0000 (10:06 -0700)
Replace all remaining handling of GRAPHICS_VER {==,>=} 10 with
{==,>=} 11. With the removal of CNL, there is no platform with graphics
version equals 10.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210728220326.1578242-5-lucas.demarchi@intel.com
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c
drivers/gpu/drm/i915/gt/intel_engine_cs.c
drivers/gpu/drm/i915/gt/intel_ggtt.c
drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
drivers/gpu/drm/i915/gt/intel_gtt.c
drivers/gpu/drm/i915/gt/intel_lrc.c
drivers/gpu/drm/i915/gt/intel_rc6.c
drivers/gpu/drm/i915/gt/intel_rps.c
drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c

index 4270b5a34a838085ed283320c3ec628049349657..d6f5836396f8d316402dc95ed2f38fd60ab39a26 100644 (file)
@@ -437,20 +437,20 @@ static int frequency_show(struct seq_file *m, void *unused)
                max_freq = (IS_GEN9_LP(i915) ? rp_state_cap >> 0 :
                            rp_state_cap >> 16) & 0xff;
                max_freq *= (IS_GEN9_BC(i915) ||
-                            GRAPHICS_VER(i915) >= 10 ? GEN9_FREQ_SCALER : 1);
+                            GRAPHICS_VER(i915) >= 11 ? GEN9_FREQ_SCALER : 1);
                seq_printf(m, "Lowest (RPN) frequency: %dMHz\n",
                           intel_gpu_freq(rps, max_freq));
 
                max_freq = (rp_state_cap & 0xff00) >> 8;
                max_freq *= (IS_GEN9_BC(i915) ||
-                            GRAPHICS_VER(i915) >= 10 ? GEN9_FREQ_SCALER : 1);
+                            GRAPHICS_VER(i915) >= 11 ? GEN9_FREQ_SCALER : 1);
                seq_printf(m, "Nominal (RP1) frequency: %dMHz\n",
                           intel_gpu_freq(rps, max_freq));
 
                max_freq = (IS_GEN9_LP(i915) ? rp_state_cap >> 16 :
                            rp_state_cap >> 0) & 0xff;
                max_freq *= (IS_GEN9_BC(i915) ||
-                            GRAPHICS_VER(i915) >= 10 ? GEN9_FREQ_SCALER : 1);
+                            GRAPHICS_VER(i915) >= 11 ? GEN9_FREQ_SCALER : 1);
                seq_printf(m, "Max non-overclocked (RP0) frequency: %dMHz\n",
                           intel_gpu_freq(rps, max_freq));
                seq_printf(m, "Max overclocked frequency: %dMHz\n",
@@ -500,7 +500,7 @@ static int llc_show(struct seq_file *m, void *data)
 
        min_gpu_freq = rps->min_freq;
        max_gpu_freq = rps->max_freq;
-       if (IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 10) {
+       if (IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 11) {
                /* Convert GT frequency to 50 HZ units */
                min_gpu_freq /= GEN9_FREQ_SCALER;
                max_gpu_freq /= GEN9_FREQ_SCALER;
@@ -518,7 +518,7 @@ static int llc_show(struct seq_file *m, void *data)
                           intel_gpu_freq(rps,
                                          (gpu_freq *
                                           (IS_GEN9_BC(i915) ||
-                                           GRAPHICS_VER(i915) >= 10 ?
+                                           GRAPHICS_VER(i915) >= 11 ?
                                            GEN9_FREQ_SCALER : 1))),
                           ((ia_freq >> 0) & 0xff) * 100,
                           ((ia_freq >> 8) & 0xff) * 100);
index dea0e522c5c727d2881ff2cdd54b2f66c19f1cf5..0d9105a31d84ecc205aa976a1ee580a8b27c25cd 100644 (file)
@@ -35,7 +35,6 @@
 #define DEFAULT_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
 #define GEN8_LR_CONTEXT_RENDER_SIZE    (20 * PAGE_SIZE)
 #define GEN9_LR_CONTEXT_RENDER_SIZE    (22 * PAGE_SIZE)
-#define GEN10_LR_CONTEXT_RENDER_SIZE   (18 * PAGE_SIZE)
 #define GEN11_LR_CONTEXT_RENDER_SIZE   (14 * PAGE_SIZE)
 
 #define GEN8_LR_CONTEXT_OTHER_SIZE     ( 2 * PAGE_SIZE)
@@ -186,8 +185,6 @@ u32 intel_engine_context_size(struct intel_gt *gt, u8 class)
                case 12:
                case 11:
                        return GEN11_LR_CONTEXT_RENDER_SIZE;
-               case 10:
-                       return GEN10_LR_CONTEXT_RENDER_SIZE;
                case 9:
                        return GEN9_LR_CONTEXT_RENDER_SIZE;
                case 8:
index 9d445ad9a34224901f393430f969f399483e86b9..de3ac58fceec3dd59968b744a258188f4939da81 100644 (file)
@@ -826,13 +826,13 @@ static int ggtt_probe_common(struct i915_ggtt *ggtt, u64 size)
        phys_addr = pci_resource_start(pdev, 0) + pci_resource_len(pdev, 0) / 2;
 
        /*
-        * On BXT+/CNL+ writes larger than 64 bit to the GTT pagetable range
+        * On BXT+/ICL+ writes larger than 64 bit to the GTT pagetable range
         * will be dropped. For WC mappings in general we have 64 byte burst
         * writes when the WC buffer is flushed, so we can't use it, but have to
         * resort to an uncached mapping. The WC issue is easily caught by the
         * readback check when writing GTT PTE entries.
         */
-       if (IS_GEN9_LP(i915) || GRAPHICS_VER(i915) >= 10)
+       if (IS_GEN9_LP(i915) || GRAPHICS_VER(i915) >= 11)
                ggtt->gsm = ioremap(phys_addr, size);
        else
                ggtt->gsm = ioremap_wc(phys_addr, size);
index 9f0e729d2d15b4de3cc4f2e9431fce6959ac4393..3513d6f907476a82018001bb3a23b87715ccfac8 100644 (file)
@@ -24,8 +24,8 @@ static u32 read_reference_ts_freq(struct intel_uncore *uncore)
        return base_freq + frac_freq;
 }
 
-static u32 gen10_get_crystal_clock_freq(struct intel_uncore *uncore,
-                                       u32 rpm_config_reg)
+static u32 gen9_get_crystal_clock_freq(struct intel_uncore *uncore,
+                                      u32 rpm_config_reg)
 {
        u32 f19_2_mhz = 19200000;
        u32 f24_mhz = 24000000;
@@ -128,10 +128,10 @@ static u32 read_clock_frequency(struct intel_uncore *uncore)
                } else {
                        u32 c0 = intel_uncore_read(uncore, RPM_CONFIG0);
 
-                       if (GRAPHICS_VER(uncore->i915) <= 10)
-                               freq = gen10_get_crystal_clock_freq(uncore, c0);
-                       else
+                       if (GRAPHICS_VER(uncore->i915) >= 11)
                                freq = gen11_get_crystal_clock_freq(uncore, c0);
+                       else
+                               freq = gen9_get_crystal_clock_freq(uncore, c0);
 
                        /*
                         * Now figure out how the command stream's timestamp
index f7e0352edb6266c618d98df528bfb6c7f1b1a83d..e137dd32b5b8ba6b723258b406f009a2908b7d1d 100644 (file)
@@ -426,7 +426,7 @@ static void tgl_setup_private_ppat(struct intel_uncore *uncore)
        intel_uncore_write(uncore, GEN12_PAT_INDEX(7), GEN8_PPAT_WB);
 }
 
-static void cnl_setup_private_ppat(struct intel_uncore *uncore)
+static void icl_setup_private_ppat(struct intel_uncore *uncore)
 {
        intel_uncore_write(uncore,
                           GEN10_PAT_INDEX(0),
@@ -526,8 +526,8 @@ void setup_private_pat(struct intel_uncore *uncore)
 
        if (GRAPHICS_VER(i915) >= 12)
                tgl_setup_private_ppat(uncore);
-       else if (GRAPHICS_VER(i915) >= 10)
-               cnl_setup_private_ppat(uncore);
+       else if (GRAPHICS_VER(i915) >= 11)
+               icl_setup_private_ppat(uncore);
        else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915))
                chv_setup_private_ppat(uncore);
        else
index c3f5bec8ae151af591ea4e67a653b7d7ab01a2eb..bb4af4977920a073fb82f62fafe677f559668286 100644 (file)
@@ -70,7 +70,7 @@ static void set_offsets(u32 *regs,
        if (close) {
                /* Close the batch; used mainly by live_lrc_layout() */
                *regs = MI_BATCH_BUFFER_END;
-               if (GRAPHICS_VER(engine->i915) >= 10)
+               if (GRAPHICS_VER(engine->i915) >= 11)
                        *regs |= BIT(0);
        }
 }
@@ -653,8 +653,6 @@ lrc_ring_indirect_offset_default(const struct intel_engine_cs *engine)
                return GEN12_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT;
        case 11:
                return GEN11_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT;
-       case 10:
-               return GEN10_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT;
        case 9:
                return GEN9_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT;
        case 8:
@@ -1448,40 +1446,6 @@ static u32 *gen9_init_indirectctx_bb(struct intel_engine_cs *engine, u32 *batch)
        return batch;
 }
 
-static u32 *
-gen10_init_indirectctx_bb(struct intel_engine_cs *engine, u32 *batch)
-{
-       int i;
-
-       /*
-        * WaPipeControlBefore3DStateSamplePattern: cnl
-        *
-        * Ensure the engine is idle prior to programming a
-        * 3DSTATE_SAMPLE_PATTERN during a context restore.
-        */
-       batch = gen8_emit_pipe_control(batch,
-                                      PIPE_CONTROL_CS_STALL,
-                                      0);
-       /*
-        * WaPipeControlBefore3DStateSamplePattern says we need 4 dwords for
-        * the PIPE_CONTROL followed by 12 dwords of 0x0, so 16 dwords in
-        * total. However, a PIPE_CONTROL is 6 dwords long, not 4, which is
-        * confusing. Since gen8_emit_pipe_control() already advances the
-        * batch by 6 dwords, we advance the other 10 here, completing a
-        * cacheline. It's not clear if the workaround requires this padding
-        * before other commands, or if it's just the regular padding we would
-        * already have for the workaround bb, so leave it here for now.
-        */
-       for (i = 0; i < 10; i++)
-               *batch++ = MI_NOOP;
-
-       /* Pad to end of cacheline */
-       while ((unsigned long)batch % CACHELINE_BYTES)
-               *batch++ = MI_NOOP;
-
-       return batch;
-}
-
 #define CTX_WA_BB_SIZE (PAGE_SIZE)
 
 static int lrc_create_wa_ctx(struct intel_engine_cs *engine)
@@ -1534,10 +1498,6 @@ void lrc_init_wa_ctx(struct intel_engine_cs *engine)
        case 12:
        case 11:
                return;
-       case 10:
-               wa_bb_fn[0] = gen10_init_indirectctx_bb;
-               wa_bb_fn[1] = NULL;
-               break;
        case 9:
                wa_bb_fn[0] = gen9_init_indirectctx_bb;
                wa_bb_fn[1] = NULL;
index 259d7eb4e165479e42c08ef4a144133d37d626e7..a7d13fe35b2e311249d05c5c93df02224fe60682 100644 (file)
@@ -126,7 +126,7 @@ static void gen9_rc6_enable(struct intel_rc6 *rc6)
        enum intel_engine_id id;
 
        /* 2b: Program RC6 thresholds.*/
-       if (GRAPHICS_VER(rc6_to_i915(rc6)) >= 10) {
+       if (GRAPHICS_VER(rc6_to_i915(rc6)) >= 11) {
                set(uncore, GEN6_RC6_WAKE_RATE_LIMIT, 54 << 16 | 85);
                set(uncore, GEN10_MEDIA_WAKE_RATE_LIMIT, 150);
        } else if (IS_SKYLAKE(rc6_to_i915(rc6))) {
index 0c8e7f2b06f00ac0d46fac17608fda682e0917d7..bc0f7d8baa8458071e220fe7820d9379084a9eb7 100644 (file)
@@ -999,7 +999,7 @@ static void gen6_rps_init(struct intel_rps *rps)
 
        rps->efficient_freq = rps->rp1_freq;
        if (IS_HASWELL(i915) || IS_BROADWELL(i915) ||
-           IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 10) {
+           IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 11) {
                u32 ddcc_status = 0;
 
                if (sandybridge_pcode_read(i915,
@@ -1012,7 +1012,7 @@ static void gen6_rps_init(struct intel_rps *rps)
                                        rps->max_freq);
        }
 
-       if (IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 10) {
+       if (IS_GEN9_BC(i915) || GRAPHICS_VER(i915) >= 11) {
                /* Store the frequency values in 16.66 MHZ units, which is
                 * the natural hardware unit for SKL
                 */
index 714fe849577537cfba9df22cae2302492243f791..5e7b09c5e36fd44c20271aa551772fac247926ce 100644 (file)
@@ -50,7 +50,7 @@ static void cherryview_sseu_device_status(struct intel_gt *gt,
 #undef SS_MAX
 }
 
-static void gen10_sseu_device_status(struct intel_gt *gt,
+static void gen11_sseu_device_status(struct intel_gt *gt,
                                     struct sseu_dev_info *sseu)
 {
 #define SS_MAX 6
@@ -267,8 +267,8 @@ int intel_sseu_status(struct seq_file *m, struct intel_gt *gt)
                        bdw_sseu_device_status(gt, &sseu);
                else if (GRAPHICS_VER(i915) == 9)
                        gen9_sseu_device_status(gt, &sseu);
-               else if (GRAPHICS_VER(i915) >= 10)
-                       gen10_sseu_device_status(gt, &sseu);
+               else if (GRAPHICS_VER(i915) >= 11)
+                       gen11_sseu_device_status(gt, &sseu);
        }
 
        i915_print_sseu_info(m, false, HAS_POOLED_EU(i915), &sseu);