]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mailbox: bcm-pdc: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:48 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/bcm-pdc-mailbox.c

index 4fe7be0bdd11f2e836897e9783b3c7fec8a7534d..ccf3d62af7e7b05a8d53ac8914cd9cbda4512bc0 100644 (file)
@@ -1471,7 +1471,7 @@ static int pdc_mb_init(struct pdc_state *pdcs)
                mbc->chans[chan_index].con_priv = pdcs;
 
        /* Register mailbox controller */
-       err = mbox_controller_register(mbc);
+       err = devm_mbox_controller_register(dev, mbc);
        if (err) {
                dev_crit(dev,
                         "Failed to register PDC mailbox controller. Error %d.",
@@ -1641,8 +1641,6 @@ static int pdc_remove(struct platform_device *pdev)
 
        pdc_hw_disable(pdcs);
 
-       mbox_controller_unregister(&pdcs->mbc);
-
        dma_pool_destroy(pdcs->rx_buf_pool);
        dma_pool_destroy(pdcs->ring_pool);
        return 0;