]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe/xe2: Add proper check for media in Wa_14020756599
authorLucas De Marchi <lucas.demarchi@intel.com>
Tue, 18 Jun 2024 05:00:44 +0000 (22:00 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Tue, 18 Jun 2024 19:03:30 +0000 (12:03 -0700)
A temporary fixup was made in commit 24d0d98af1c3 ("drm/xe/xe2lpm: Fixup
Wa_14020756599") due to limitations in the RTP infra. Now that RTP has
support for OR condition that change can be removed. RTP now also
supports checking any GT, so use that instead of the more specific
xe_rtp_match_when_media2000() used in that commit.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240618050044.324454-6-lucas.demarchi@intel.com
drivers/gpu/drm/xe/xe_wa.c

index a2725a150441a30e0a49e554a5a816c6dd6d1e30..0b6fbbebc41e3f0dba4bd2df4d3dfe73f76f47c2 100644 (file)
@@ -677,15 +677,9 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
                       ENGINE_CLASS(RENDER)),
          XE_RTP_ACTIONS(SET(CHICKEN_RASTER_2, TBIMR_FAST_CLIP))
        },
-       /*
-        * This WA is also needed on primary GT when the media version is 2000.
-        * Currently, media version 2000 is always paired with graphics version
-        * 2004, so just checking the latter is sufficient. In the future, media
-        * version 2000 can be used with some other graphics version where WA
-        * still needs to be implemented
-        */
        { XE_RTP_NAME("14020756599"),
-         XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER)),
+         XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER), OR,
+                      MEDIA_VERSION_ANY_GT(2000), ENGINE_CLASS(RENDER)),
          XE_RTP_ACTIONS(SET(WM_CHICKEN3, HIZ_PLANE_COMPRESSION_DIS))
        },
        { XE_RTP_NAME("14021490052"),