]> git.ipfire.org Git - pakfire.git/commitdiff
file: Do not check for ELF status again when dumping issues
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 17 Mar 2023 13:57:33 +0000 (13:57 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 17 Mar 2023 13:57:33 +0000 (13:57 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/libpakfire/file.c

index 24a76553e6b3339b70aa42cba56d7f4802ddda3e..f657d941b73623625e96eb7ca09f30990248360f 100644 (file)
@@ -629,34 +629,32 @@ char* pakfire_file_dump(struct pakfire_file* file, int flags) {
                                goto ERROR;
                }
 
-               if (pakfire_file_matches_class(file, PAKFIRE_FILE_ELF)) {
-                       // Stack-smashing Protection
-                       if (file->issues & PAKFIRE_FILE_NO_SSP) {
-                               r = asprintf(&buffer, "%s [NO-SSP]", buffer);
-                               if (r < 0)
-                                       goto ERROR;
-                       }
+               // Stack-smashing Protection
+               if (file->issues & PAKFIRE_FILE_NO_SSP) {
+                       r = asprintf(&buffer, "%s [NO-SSP]", buffer);
+                       if (r < 0)
+                               goto ERROR;
+               }
 
-                       // Position-independent Executable
-                       if (file->issues & PAKFIRE_FILE_NO_PIE) {
-                               r = asprintf(&buffer, "%s [NO-PIE]", buffer);
-                               if (r < 0)
-                                       goto ERROR;
-                       }
+               // Position-independent Executable
+               if (file->issues & PAKFIRE_FILE_NO_PIE) {
+                       r = asprintf(&buffer, "%s [NO-PIE]", buffer);
+                       if (r < 0)
+                               goto ERROR;
+               }
 
-                       // Executable Stack
-                       if (file->issues & PAKFIRE_FILE_EXECSTACK) {
-                               r = asprintf(&buffer, "%s [EXECSTACK]", buffer);
-                               if (r < 0)
-                                       goto ERROR;
-                       }
+               // Executable Stack
+               if (file->issues & PAKFIRE_FILE_EXECSTACK) {
+                       r = asprintf(&buffer, "%s [EXECSTACK]", buffer);
+                       if (r < 0)
+                               goto ERROR;
+               }
 
-                       // Not Partially RELRO
-                       if (file->issues & PAKFIRE_FILE_NO_PARTIALLY_RELRO) {
-                               r = asprintf(&buffer, "%s [NO-PART-RELRO]", buffer);
-                               if (r < 0)
-                                       goto ERROR;
-                       }
+               // Not Partially RELRO
+               if (file->issues & PAKFIRE_FILE_NO_PARTIALLY_RELRO) {
+                       r = asprintf(&buffer, "%s [NO-PART-RELRO]", buffer);
+                       if (r < 0)
+                               goto ERROR;
                }
        }