]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: domain: Don't check return value of 'virCPUDefCopy'
authorPeter Krempa <pkrempa@redhat.com>
Wed, 2 Apr 2025 07:45:19 +0000 (09:45 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 2 Apr 2025 14:51:40 +0000 (16:51 +0200)
As 'virCPUDefCopy' can't fail any more (without aborting) remove the
last two return value checks.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index e45eef47876a12defa21acf6f5c2d8d1b22c5d6d..c3ca4b30402aa2cf432fbd73b922cb09cb60f26c 100644 (file)
@@ -5321,8 +5321,7 @@ qemuDomainDefFormatBufInternal(virQEMUDriver *driver,
          */
         if (origCPU) {
             virCPUDefFree(def->cpu);
-            if (!(def->cpu = virCPUDefCopy(origCPU)))
-                return -1;
+            def->cpu = virCPUDefCopy(origCPU);
         }
 
         if (def->cpu &&
@@ -9354,8 +9353,8 @@ qemuDomainSaveCookieNew(virDomainObj *vm)
     if (!(cookie = virObjectNew(qemuDomainSaveCookieClass)))
         return NULL;
 
-    if (priv->origCPU && !(cookie->cpu = virCPUDefCopy(vm->def->cpu)))
-        return NULL;
+    if (priv->origCPU)
+        cookie->cpu = virCPUDefCopy(vm->def->cpu);
 
     cookie->slirpHelper = qemuDomainGetSlirpHelperOk(vm);