]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
eth: fbnic: don't disable the PCI device twice
authorJakub Kicinski <kuba@kernel.org>
Fri, 15 Nov 2024 01:48:09 +0000 (17:48 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 02:43:11 +0000 (18:43 -0800)
We use pcim_enable_device(), there is no need to call pci_disable_device().

Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241115014809.754860-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_pci.c

index a4809fe0fc2496c9cb4371049d8314b68bd47023..268489b15616fd07b7378a929240cbed3708f971 100644 (file)
@@ -319,7 +319,6 @@ init_failure_mode:
 free_irqs:
        fbnic_free_irqs(fbd);
 free_fbd:
-       pci_disable_device(pdev);
        fbnic_devlink_free(fbd);
 
        return err;
@@ -349,7 +348,6 @@ static void fbnic_remove(struct pci_dev *pdev)
        fbnic_fw_disable_mbx(fbd);
        fbnic_free_irqs(fbd);
 
-       pci_disable_device(pdev);
        fbnic_devlink_free(fbd);
 }