]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
power: reset: xgene-reboot: Fix a NULL vs IS_ERR() test
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 20 Feb 2024 09:02:22 +0000 (12:02 +0300)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 21 Feb 2024 20:13:37 +0000 (21:13 +0100)
The devm_platform_ioremap_resource() function returns error points.  It
never returns NULL.  Update the check accordingly.

Fixes: 7ddfd33c6ee5 ("power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/fe1b90d0-7234-4e03-accc-69a119f6a7eb@moroto.mountain
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/reset/xgene-reboot.c

index 867162dfe7eaeff2d9a18a59e3642d1340d55362..b5eee19bac4261f83fe199c370339834e684c7e9 100644 (file)
@@ -51,9 +51,9 @@ static int xgene_reboot_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        ctx->csr = devm_platform_ioremap_resource(pdev, 0);
-       if (!ctx->csr) {
+       if (IS_ERR(ctx->csr)) {
                dev_err(dev, "can not map resource\n");
-               return -ENODEV;
+               return PTR_ERR(ctx->csr);
        }
 
        if (of_property_read_u32(dev->of_node, "mask", &ctx->mask))