]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-proxy: Remove unnecessary "disconnecting" text from log message
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Apr 2020 21:31:41 +0000 (00:31 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Fri, 24 Apr 2020 08:02:40 +0000 (08:02 +0000)
Add "Disconnected by proxy: " prefix explicitly for the few reasons why
the proxy itself is causing the disconnection.

src/login-common/login-proxy.c

index 082c0ebd2476a5d7a1f226a3d0aff6cb8a56bc37..0469dc9e90ae2f2ac25988210c8f83d0ee483bf6 100644 (file)
@@ -26,9 +26,9 @@
 #define LOGIN_PROXY_DIE_IDLE_SECS 2
 #define LOGIN_PROXY_IPC_PATH "ipc-proxy"
 #define LOGIN_PROXY_IPC_NAME "proxy"
-#define KILLED_BY_ADMIN_REASON "Kicked by admin"
-#define KILLED_BY_DIRECTOR_REASON "Kicked via director"
-#define KILLED_BY_SHUTDOWN_REASON "Process shutting down"
+#define KILLED_BY_ADMIN_REASON "Disconnected by proxy: Kicked by admin"
+#define KILLED_BY_DIRECTOR_REASON "Disconnected by proxy: Kicked via director"
+#define KILLED_BY_SHUTDOWN_REASON "Disconnected by proxy: Process shutting down"
 #define PROXY_IMMEDIATE_FAILURE_SECS 30
 #define PROXY_CONNECT_RETRY_MSECS 1000
 #define PROXY_DISCONNECT_INTERVAL_MSECS 100
@@ -480,8 +480,12 @@ login_proxy_free_full(struct login_proxy **_proxy, const char *reason,
                if ((flags & LOGIN_PROXY_FREE_FLAG_DELAYED) != 0)
                        delay_ms = login_proxy_delay_disconnect(proxy);
 
-               e_info(proxy->event, "disconnecting (%s)%s", reason,
-                      delay_ms == 0 ? "" : t_strdup_printf(" - disconnecting client in %ums", delay_ms));
+               if (delay_ms == 0)
+                       e_info(proxy->event, "%s", reason);
+               else {
+                       e_info(proxy->event, "%s - disconnecting client in %ums",
+                              reason, delay_ms);
+               }
 
                i_assert(detached_login_proxies_count > 0);
                detached_login_proxies_count--;