]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
Fixes for 5.10
authorSasha Levin <sashal@kernel.org>
Sat, 1 Mar 2025 14:19:56 +0000 (09:19 -0500)
committerSasha Levin <sashal@kernel.org>
Sat, 1 Mar 2025 14:19:56 +0000 (09:19 -0500)
Signed-off-by: Sasha Levin <sashal@kernel.org>
15 files changed:
queue-5.10/alsa-usb-audio-avoid-dropping-midi-events-at-closing.patch [new file with mode: 0644]
queue-5.10/asoc-es8328-fix-route-from-dac-to-output.patch [new file with mode: 0644]
queue-5.10/bluetooth-l2cap-fix-l2cap_ecred_conn_rsp-response.patch [new file with mode: 0644]
queue-5.10/include-net-add-static-inline-dst_dev_overhead-to-ds.patch [new file with mode: 0644]
queue-5.10/ipvs-always-clear-ipvs_property-flag-in-skb_scrub_pa.patch [new file with mode: 0644]
queue-5.10/net-cadence-macb-synchronize-stats-calculations.patch [new file with mode: 0644]
queue-5.10/net-ipv6-fix-dst-ref-loop-on-input-in-rpl-lwt.patch [new file with mode: 0644]
queue-5.10/net-ipv6-rpl_iptunnel-mitigate-2-realloc-issue.patch [new file with mode: 0644]
queue-5.10/net-ipv6-rpl_iptunnel-simplify-the-return-expression.patch [new file with mode: 0644]
queue-5.10/net-loopback-avoid-sending-ip-packets-without-an-eth.patch [new file with mode: 0644]
queue-5.10/net-mvpp2-cls-fixed-non-ip-flow-with-vlan-tag-flow-d.patch [new file with mode: 0644]
queue-5.10/net-use-indirect-call-helpers-for-dst_input.patch [new file with mode: 0644]
queue-5.10/net-use-indirect-call-helpers-for-dst_output.patch [new file with mode: 0644]
queue-5.10/series
queue-5.10/tcp-defer-ts_recent-changes-until-req-is-owned.patch [new file with mode: 0644]

diff --git a/queue-5.10/alsa-usb-audio-avoid-dropping-midi-events-at-closing.patch b/queue-5.10/alsa-usb-audio-avoid-dropping-midi-events-at-closing.patch
new file mode 100644 (file)
index 0000000..c685026
--- /dev/null
@@ -0,0 +1,47 @@
+From c8f9763d90680d4f8989877e6305aab181323a7e Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 18 Feb 2025 12:40:24 +0100
+Subject: ALSA: usb-audio: Avoid dropping MIDI events at closing multiple ports
+
+From: Takashi Iwai <tiwai@suse.de>
+
+[ Upstream commit a3bdd8f5c2217e1cb35db02c2eed36ea20fb50f5 ]
+
+We fixed the UAF issue in USB MIDI code by canceling the pending work
+at closing each MIDI output device in the commit below.  However, this
+assumed that it's the only one that is tied with the endpoint, and it
+resulted in unexpected data truncations when multiple devices are
+assigned to a single endpoint and opened simultaneously.
+
+For addressing the unexpected MIDI message drops, simply replace
+cancel_work_sync() with flush_work().  The drain callback should have
+been already invoked before the close callback, hence the port->active
+flag must be already cleared.  So this just assures that the pending
+work is finished before freeing the resources.
+
+Fixes: 0125de38122f ("ALSA: usb-audio: Cancel pending work at closing a MIDI substream")
+Reported-and-tested-by: John Keeping <jkeeping@inmusicbrands.com>
+Closes: https://lore.kernel.org/20250217111647.3368132-1-jkeeping@inmusicbrands.com
+Link: https://patch.msgid.link/20250218114024.23125-1-tiwai@suse.de
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ sound/usb/midi.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/sound/usb/midi.c b/sound/usb/midi.c
+index b02e1a33304f0..f0a70e912bddc 100644
+--- a/sound/usb/midi.c
++++ b/sound/usb/midi.c
+@@ -1161,7 +1161,7 @@ static int snd_usbmidi_output_close(struct snd_rawmidi_substream *substream)
+ {
+       struct usbmidi_out_port *port = substream->runtime->private_data;
+-      cancel_work_sync(&port->ep->work);
++      flush_work(&port->ep->work);
+       return substream_open(substream, 0, 0);
+ }
+-- 
+2.39.5
+
diff --git a/queue-5.10/asoc-es8328-fix-route-from-dac-to-output.patch b/queue-5.10/asoc-es8328-fix-route-from-dac-to-output.patch
new file mode 100644 (file)
index 0000000..a31816b
--- /dev/null
@@ -0,0 +1,110 @@
+From 67f6e8c78ac645de012fdf5cb82df1915325a3dc Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Sat, 22 Feb 2025 20:39:57 +0100
+Subject: ASoC: es8328: fix route from DAC to output
+
+From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
+
+[ Upstream commit 5b0c02f9b8acf2a791e531bbc09acae2d51f4f9b ]
+
+The ES8328 codec driver, which is also used for the ES8388 chip that
+appears to have an identical register map, claims that the output can
+either take the route from DAC->Mixer->Output or through DAC->Output
+directly. To the best of what I could find, this is not true, and
+creates problems.
+
+Without DACCONTROL17 bit index 7 set for the left channel, as well as
+DACCONTROL20 bit index 7 set for the right channel, I cannot get any
+analog audio out on Left Out 2 and Right Out 2 respectively, despite the
+DAPM routes claiming that this should be possible. Furthermore, the same
+is the case for Left Out 1 and Right Out 1, showing that those two don't
+have a direct route from DAC to output bypassing the mixer either.
+
+Those control bits toggle whether the DACs are fed (stale bread?) into
+their respective mixers. If one "unmutes" the mixer controls in
+alsamixer, then sure, the audio output works, but if it doesn't work
+without the mixer being fed the DAC input then evidently it's not a
+direct output from the DAC.
+
+ES8328/ES8388 are seemingly not alone in this. ES8323, which uses a
+separate driver for what appears to be a very similar register map,
+simply flips those two bits on in its probe function, and then pretends
+there is no power management whatsoever for the individual controls.
+Fair enough.
+
+My theory as to why nobody has noticed this up to this point is that
+everyone just assumes it's their fault when they had to unmute an
+additional control in ALSA.
+
+Fix this in the es8328 driver by removing the erroneous direct route,
+then get rid of the playback switch controls and have those bits tied to
+the mixer's widget instead, which until now had no register to play
+with.
+
+Fixes: 567e4f98922c ("ASoC: add es8328 codec driver")
+Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
+Link: https://patch.msgid.link/20250222-es8328-route-bludgeoning-v1-1-99bfb7fb22d9@collabora.com
+Signed-off-by: Mark Brown <broonie@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ sound/soc/codecs/es8328.c | 15 ++++-----------
+ 1 file changed, 4 insertions(+), 11 deletions(-)
+
+diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
+index 081b5f189632e..60ad9f3683fe9 100644
+--- a/sound/soc/codecs/es8328.c
++++ b/sound/soc/codecs/es8328.c
+@@ -234,7 +234,6 @@ static const struct snd_kcontrol_new es8328_right_line_controls =
+ /* Left Mixer */
+ static const struct snd_kcontrol_new es8328_left_mixer_controls[] = {
+-      SOC_DAPM_SINGLE("Playback Switch", ES8328_DACCONTROL17, 7, 1, 0),
+       SOC_DAPM_SINGLE("Left Bypass Switch", ES8328_DACCONTROL17, 6, 1, 0),
+       SOC_DAPM_SINGLE("Right Playback Switch", ES8328_DACCONTROL18, 7, 1, 0),
+       SOC_DAPM_SINGLE("Right Bypass Switch", ES8328_DACCONTROL18, 6, 1, 0),
+@@ -244,7 +243,6 @@ static const struct snd_kcontrol_new es8328_left_mixer_controls[] = {
+ static const struct snd_kcontrol_new es8328_right_mixer_controls[] = {
+       SOC_DAPM_SINGLE("Left Playback Switch", ES8328_DACCONTROL19, 7, 1, 0),
+       SOC_DAPM_SINGLE("Left Bypass Switch", ES8328_DACCONTROL19, 6, 1, 0),
+-      SOC_DAPM_SINGLE("Playback Switch", ES8328_DACCONTROL20, 7, 1, 0),
+       SOC_DAPM_SINGLE("Right Bypass Switch", ES8328_DACCONTROL20, 6, 1, 0),
+ };
+@@ -337,10 +335,10 @@ static const struct snd_soc_dapm_widget es8328_dapm_widgets[] = {
+       SND_SOC_DAPM_DAC("Left DAC", "Left Playback", ES8328_DACPOWER,
+                       ES8328_DACPOWER_LDAC_OFF, 1),
+-      SND_SOC_DAPM_MIXER("Left Mixer", SND_SOC_NOPM, 0, 0,
++      SND_SOC_DAPM_MIXER("Left Mixer", ES8328_DACCONTROL17, 7, 0,
+               &es8328_left_mixer_controls[0],
+               ARRAY_SIZE(es8328_left_mixer_controls)),
+-      SND_SOC_DAPM_MIXER("Right Mixer", SND_SOC_NOPM, 0, 0,
++      SND_SOC_DAPM_MIXER("Right Mixer", ES8328_DACCONTROL20, 7, 0,
+               &es8328_right_mixer_controls[0],
+               ARRAY_SIZE(es8328_right_mixer_controls)),
+@@ -419,19 +417,14 @@ static const struct snd_soc_dapm_route es8328_dapm_routes[] = {
+       { "Right Line Mux", "PGA", "Right PGA Mux" },
+       { "Right Line Mux", "Differential", "Differential Mux" },
+-      { "Left Out 1", NULL, "Left DAC" },
+-      { "Right Out 1", NULL, "Right DAC" },
+-      { "Left Out 2", NULL, "Left DAC" },
+-      { "Right Out 2", NULL, "Right DAC" },
+-
+-      { "Left Mixer", "Playback Switch", "Left DAC" },
++      { "Left Mixer", NULL, "Left DAC" },
+       { "Left Mixer", "Left Bypass Switch", "Left Line Mux" },
+       { "Left Mixer", "Right Playback Switch", "Right DAC" },
+       { "Left Mixer", "Right Bypass Switch", "Right Line Mux" },
+       { "Right Mixer", "Left Playback Switch", "Left DAC" },
+       { "Right Mixer", "Left Bypass Switch", "Left Line Mux" },
+-      { "Right Mixer", "Playback Switch", "Right DAC" },
++      { "Right Mixer", NULL, "Right DAC" },
+       { "Right Mixer", "Right Bypass Switch", "Right Line Mux" },
+       { "DAC DIG", NULL, "DAC STM" },
+-- 
+2.39.5
+
diff --git a/queue-5.10/bluetooth-l2cap-fix-l2cap_ecred_conn_rsp-response.patch b/queue-5.10/bluetooth-l2cap-fix-l2cap_ecred_conn_rsp-response.patch
new file mode 100644 (file)
index 0000000..b4e1701
--- /dev/null
@@ -0,0 +1,99 @@
+From 2f1c0568585c4c03150a6b2b7dd3a3021d2961bc Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Fri, 14 Feb 2025 10:30:25 -0500
+Subject: Bluetooth: L2CAP: Fix L2CAP_ECRED_CONN_RSP response
+
+From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+
+[ Upstream commit b25120e1d5f2ebb3db00af557709041f47f7f3d0 ]
+
+L2CAP_ECRED_CONN_RSP needs to respond DCID in the same order received as
+SCID but the order is reversed due to use of list_add which actually
+prepend channels to the list so the response is reversed:
+
+> ACL Data RX: Handle 16 flags 0x02 dlen 26
+      LE L2CAP: Enhanced Credit Connection Request (0x17) ident 2 len 18
+        PSM: 39 (0x0027)
+        MTU: 256
+        MPS: 251
+        Credits: 65535
+        Source CID: 116
+        Source CID: 117
+        Source CID: 118
+        Source CID: 119
+        Source CID: 120
+< ACL Data TX: Handle 16 flags 0x00 dlen 26
+      LE L2CAP: Enhanced Credit Connection Response (0x18) ident 2 len 18
+        MTU: 517
+        MPS: 247
+        Credits: 3
+        Result: Connection successful (0x0000)
+        Destination CID: 68
+        Destination CID: 67
+        Destination CID: 66
+        Destination CID: 65
+        Destination CID: 64
+
+Also make sure the response don't include channels that are not on
+BT_CONNECT2 since the chan->ident can be set to the same value as in the
+following trace:
+
+< ACL Data TX: Handle 16 flags 0x00 dlen 12
+      LE L2CAP: LE Flow Control Credit (0x16) ident 6 len 4
+        Source CID: 64
+        Credits: 1
+...
+> ACL Data RX: Handle 16 flags 0x02 dlen 18
+      LE L2CAP: Enhanced Credit Connection Request (0x17) ident 6 len 10
+        PSM: 39 (0x0027)
+        MTU: 517
+        MPS: 251
+        Credits: 255
+        Source CID: 70
+< ACL Data TX: Handle 16 flags 0x00 dlen 20
+      LE L2CAP: Enhanced Credit Connection Response (0x18) ident 6 len 12
+        MTU: 517
+        MPS: 247
+        Credits: 3
+        Result: Connection successful (0x0000)
+        Destination CID: 64
+        Destination CID: 68
+
+Closes: https://github.com/bluez/bluez/issues/1094
+Fixes: 9aa9d9473f15 ("Bluetooth: L2CAP: Fix responding with wrong PDU type")
+Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/bluetooth/l2cap_core.c | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
+index 23fc03f7bf312..be281a95a0a8b 100644
+--- a/net/bluetooth/l2cap_core.c
++++ b/net/bluetooth/l2cap_core.c
+@@ -632,7 +632,8 @@ void __l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
+           test_bit(FLAG_HOLD_HCI_CONN, &chan->flags))
+               hci_conn_hold(conn->hcon);
+-      list_add(&chan->list, &conn->chan_l);
++      /* Append to the list since the order matters for ECRED */
++      list_add_tail(&chan->list, &conn->chan_l);
+ }
+ void l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
+@@ -3967,7 +3968,11 @@ static void l2cap_ecred_rsp_defer(struct l2cap_chan *chan, void *data)
+ {
+       struct l2cap_ecred_rsp_data *rsp = data;
+-      if (test_bit(FLAG_ECRED_CONN_REQ_SENT, &chan->flags))
++      /* Check if channel for outgoing connection or if it wasn't deferred
++       * since in those cases it must be skipped.
++       */
++      if (test_bit(FLAG_ECRED_CONN_REQ_SENT, &chan->flags) ||
++          !test_and_clear_bit(FLAG_DEFER_SETUP, &chan->flags))
+               return;
+       /* Reset ident so only one response is sent */
+-- 
+2.39.5
+
diff --git a/queue-5.10/include-net-add-static-inline-dst_dev_overhead-to-ds.patch b/queue-5.10/include-net-add-static-inline-dst_dev_overhead-to-ds.patch
new file mode 100644 (file)
index 0000000..1df9d1c
--- /dev/null
@@ -0,0 +1,49 @@
+From 2ad1a6890645eb3b71949e5cac2e3c7ff63dc101 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 3 Dec 2024 13:49:42 +0100
+Subject: include: net: add static inline dst_dev_overhead() to dst.h
+
+From: Justin Iurman <justin.iurman@uliege.be>
+
+[ Upstream commit 0600cf40e9b36fe17f9c9f04d4f9cef249eaa5e7 ]
+
+Add static inline dst_dev_overhead() function to include/net/dst.h. This
+helper function is used by ioam6_iptunnel, rpl_iptunnel and
+seg6_iptunnel to get the dev's overhead based on a cache entry
+(dst_entry). If the cache is empty, the default and generic value
+skb->mac_len is returned. Otherwise, LL_RESERVED_SPACE() over dst's dev
+is returned.
+
+Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
+Cc: Alexander Lobakin <aleksander.lobakin@intel.com>
+Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Stable-dep-of: 13e55fbaec17 ("net: ipv6: fix dst ref loop on input in rpl lwt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ include/net/dst.h | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/include/net/dst.h b/include/net/dst.h
+index af57a6284444c..9114272f81009 100644
+--- a/include/net/dst.h
++++ b/include/net/dst.h
+@@ -431,6 +431,15 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout)
+               dst->expires = expires;
+ }
++static inline unsigned int dst_dev_overhead(struct dst_entry *dst,
++                                          struct sk_buff *skb)
++{
++      if (likely(dst))
++              return LL_RESERVED_SPACE(dst->dev);
++
++      return skb->mac_len;
++}
++
+ INDIRECT_CALLABLE_DECLARE(int ip6_output(struct net *, struct sock *,
+                                        struct sk_buff *));
+ INDIRECT_CALLABLE_DECLARE(int ip_output(struct net *, struct sock *,
+-- 
+2.39.5
+
diff --git a/queue-5.10/ipvs-always-clear-ipvs_property-flag-in-skb_scrub_pa.patch b/queue-5.10/ipvs-always-clear-ipvs_property-flag-in-skb_scrub_pa.patch
new file mode 100644 (file)
index 0000000..c7439fd
--- /dev/null
@@ -0,0 +1,51 @@
+From 5be3e3af41268586e723a72cfbcc26666c0a37a3 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Sat, 22 Feb 2025 11:35:18 +0800
+Subject: ipvs: Always clear ipvs_property flag in skb_scrub_packet()
+
+From: Philo Lu <lulie@linux.alibaba.com>
+
+[ Upstream commit de2c211868b9424f9aa9b3432c4430825bafb41b ]
+
+We found an issue when using bpf_redirect with ipvs NAT mode after
+commit ff70202b2d1a ("dev_forward_skb: do not scrub skb mark within
+the same name space"). Particularly, we use bpf_redirect to return
+the skb directly back to the netif it comes from, i.e., xnet is
+false in skb_scrub_packet(), and then ipvs_property is preserved
+and SNAT is skipped in the rx path.
+
+ipvs_property has been already cleared when netns is changed in
+commit 2b5ec1a5f973 ("netfilter/ipvs: clear ipvs_property flag when
+SKB net namespace changed"). This patch just clears it in spite of
+netns.
+
+Fixes: 2b5ec1a5f973 ("netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed")
+Signed-off-by: Philo Lu <lulie@linux.alibaba.com>
+Acked-by: Julian Anastasov <ja@ssi.bg>
+Link: https://patch.msgid.link/20250222033518.126087-1-lulie@linux.alibaba.com
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/core/skbuff.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/net/core/skbuff.c b/net/core/skbuff.c
+index 754dc70293109..297a2efd6322d 100644
+--- a/net/core/skbuff.c
++++ b/net/core/skbuff.c
+@@ -5361,11 +5361,11 @@ void skb_scrub_packet(struct sk_buff *skb, bool xnet)
+       skb->offload_fwd_mark = 0;
+       skb->offload_l3_fwd_mark = 0;
+ #endif
++      ipvs_reset(skb);
+       if (!xnet)
+               return;
+-      ipvs_reset(skb);
+       skb->mark = 0;
+       skb->tstamp = 0;
+ }
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-cadence-macb-synchronize-stats-calculations.patch b/queue-5.10/net-cadence-macb-synchronize-stats-calculations.patch
new file mode 100644 (file)
index 0000000..30f12ca
--- /dev/null
@@ -0,0 +1,115 @@
+From f7ad44c493cae50940e4a7dd9ac2a5cd26d5631d Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Thu, 20 Feb 2025 11:29:50 -0500
+Subject: net: cadence: macb: Synchronize stats calculations
+
+From: Sean Anderson <sean.anderson@linux.dev>
+
+[ Upstream commit fa52f15c745ce55261b92873676f64f7348cfe82 ]
+
+Stats calculations involve a RMW to add the stat update to the existing
+value. This is currently not protected by any synchronization mechanism,
+so data races are possible. Add a spinlock to protect the update. The
+reader side could be protected using u64_stats, but we would still need
+a spinlock for the update side anyway. And we always do an update
+immediately before reading the stats anyway.
+
+Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver")
+Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
+Link: https://patch.msgid.link/20250220162950.95941-1-sean.anderson@linux.dev
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/net/ethernet/cadence/macb.h      |  2 ++
+ drivers/net/ethernet/cadence/macb_main.c | 12 ++++++++++--
+ 2 files changed, 12 insertions(+), 2 deletions(-)
+
+diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
+index 5de47f6fde5ab..7ce391209cdd1 100644
+--- a/drivers/net/ethernet/cadence/macb.h
++++ b/drivers/net/ethernet/cadence/macb.h
+@@ -1191,6 +1191,8 @@ struct macb {
+       struct clk              *rx_clk;
+       struct clk              *tsu_clk;
+       struct net_device       *dev;
++      /* Protects hw_stats and ethtool_stats */
++      spinlock_t              stats_lock;
+       union {
+               struct macb_stats       macb;
+               struct gem_stats        gem;
+diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
+index c3a8f6fc05aed..0f18837def3c8 100644
+--- a/drivers/net/ethernet/cadence/macb_main.c
++++ b/drivers/net/ethernet/cadence/macb_main.c
+@@ -1702,10 +1702,12 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id)
+               if (status & MACB_BIT(ISR_ROVR)) {
+                       /* We missed at least one packet */
++                      spin_lock(&bp->stats_lock);
+                       if (macb_is_gem(bp))
+                               bp->hw_stats.gem.rx_overruns++;
+                       else
+                               bp->hw_stats.macb.rx_overruns++;
++                      spin_unlock(&bp->stats_lock);
+                       if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE)
+                               queue_writel(queue, ISR, MACB_BIT(ISR_ROVR));
+@@ -2748,6 +2750,7 @@ static struct net_device_stats *gem_get_stats(struct macb *bp)
+       if (!netif_running(bp->dev))
+               return nstat;
++      spin_lock_irq(&bp->stats_lock);
+       gem_update_stats(bp);
+       nstat->rx_errors = (hwstat->rx_frame_check_sequence_errors +
+@@ -2777,6 +2780,7 @@ static struct net_device_stats *gem_get_stats(struct macb *bp)
+       nstat->tx_aborted_errors = hwstat->tx_excessive_collisions;
+       nstat->tx_carrier_errors = hwstat->tx_carrier_sense_errors;
+       nstat->tx_fifo_errors = hwstat->tx_underrun;
++      spin_unlock_irq(&bp->stats_lock);
+       return nstat;
+ }
+@@ -2784,12 +2788,13 @@ static struct net_device_stats *gem_get_stats(struct macb *bp)
+ static void gem_get_ethtool_stats(struct net_device *dev,
+                                 struct ethtool_stats *stats, u64 *data)
+ {
+-      struct macb *bp;
++      struct macb *bp = netdev_priv(dev);
+-      bp = netdev_priv(dev);
++      spin_lock_irq(&bp->stats_lock);
+       gem_update_stats(bp);
+       memcpy(data, &bp->ethtool_stats, sizeof(u64)
+                       * (GEM_STATS_LEN + QUEUE_STATS_LEN * MACB_MAX_QUEUES));
++      spin_unlock_irq(&bp->stats_lock);
+ }
+ static int gem_get_sset_count(struct net_device *dev, int sset)
+@@ -2839,6 +2844,7 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
+               return gem_get_stats(bp);
+       /* read stats from hardware */
++      spin_lock_irq(&bp->stats_lock);
+       macb_update_stats(bp);
+       /* Convert HW stats into netdevice stats */
+@@ -2872,6 +2878,7 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
+       nstat->tx_carrier_errors = hwstat->tx_carrier_errors;
+       nstat->tx_fifo_errors = hwstat->tx_underruns;
+       /* Don't know about heartbeat or window errors... */
++      spin_unlock_irq(&bp->stats_lock);
+       return nstat;
+ }
+@@ -4564,6 +4571,7 @@ static int macb_probe(struct platform_device *pdev)
+       device_set_wakeup_capable(&pdev->dev, bp->wol & MACB_WOL_HAS_MAGIC_PACKET);
+       spin_lock_init(&bp->lock);
++      spin_lock_init(&bp->stats_lock);
+       /* setup capabilities */
+       macb_configure_caps(bp, macb_config);
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-ipv6-fix-dst-ref-loop-on-input-in-rpl-lwt.patch b/queue-5.10/net-ipv6-fix-dst-ref-loop-on-input-in-rpl-lwt.patch
new file mode 100644 (file)
index 0000000..0f43daa
--- /dev/null
@@ -0,0 +1,60 @@
+From bd18c950f14c662ea37bd55901bcfa47c7472ef3 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 25 Feb 2025 18:51:39 +0100
+Subject: net: ipv6: fix dst ref loop on input in rpl lwt
+
+From: Justin Iurman <justin.iurman@uliege.be>
+
+[ Upstream commit 13e55fbaec176119cff68a7e1693b251c8883c5f ]
+
+Prevent a dst ref loop on input in rpl_iptunnel.
+
+Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
+Cc: Alexander Aring <alex.aring@gmail.com>
+Cc: Ido Schimmel <idosch@nvidia.com>
+Reviewed-by: Ido Schimmel <idosch@nvidia.com>
+Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv6/rpl_iptunnel.c | 14 ++++++++++++--
+ 1 file changed, 12 insertions(+), 2 deletions(-)
+
+diff --git a/net/ipv6/rpl_iptunnel.c b/net/ipv6/rpl_iptunnel.c
+index dbdfdd2e52784..95e84ec035203 100644
+--- a/net/ipv6/rpl_iptunnel.c
++++ b/net/ipv6/rpl_iptunnel.c
+@@ -259,10 +259,18 @@ static int rpl_input(struct sk_buff *skb)
+ {
+       struct dst_entry *orig_dst = skb_dst(skb);
+       struct dst_entry *dst = NULL;
++      struct lwtunnel_state *lwtst;
+       struct rpl_lwt *rlwt;
+       int err;
+-      rlwt = rpl_lwt_lwtunnel(orig_dst->lwtstate);
++      /* We cannot dereference "orig_dst" once ip6_route_input() or
++       * skb_dst_drop() is called. However, in order to detect a dst loop, we
++       * need the address of its lwtstate. So, save the address of lwtstate
++       * now and use it later as a comparison.
++       */
++      lwtst = orig_dst->lwtstate;
++
++      rlwt = rpl_lwt_lwtunnel(lwtst);
+       local_bh_disable();
+       dst = dst_cache_get(&rlwt->cache);
+@@ -277,7 +285,9 @@ static int rpl_input(struct sk_buff *skb)
+       if (!dst) {
+               ip6_route_input(skb);
+               dst = skb_dst(skb);
+-              if (!dst->error) {
++
++              /* cache only if we don't create a dst reference loop */
++              if (!dst->error && lwtst != dst->lwtstate) {
+                       local_bh_disable();
+                       dst_cache_set_ip6(&rlwt->cache, dst,
+                                         &ipv6_hdr(skb)->saddr);
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-ipv6-rpl_iptunnel-mitigate-2-realloc-issue.patch b/queue-5.10/net-ipv6-rpl_iptunnel-mitigate-2-realloc-issue.patch
new file mode 100644 (file)
index 0000000..cea0478
--- /dev/null
@@ -0,0 +1,155 @@
+From 12cbeffc0a53bc90d50d61958464e5178d7bc1f8 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 3 Dec 2024 13:49:45 +0100
+Subject: net: ipv6: rpl_iptunnel: mitigate 2-realloc issue
+
+From: Justin Iurman <justin.iurman@uliege.be>
+
+[ Upstream commit 985ec6f5e6235242191370628acb73d7a9f0c0ea ]
+
+This patch mitigates the two-reallocations issue with rpl_iptunnel by
+providing the dst_entry (in the cache) to the first call to
+skb_cow_head(). As a result, the very first iteration would still
+trigger two reallocations (i.e., empty cache), while next iterations
+would only trigger a single reallocation.
+
+Performance tests before/after applying this patch, which clearly shows
+there is no impact (it even shows improvement):
+- before: https://ibb.co/nQJhqwc
+- after: https://ibb.co/4ZvW6wV
+
+Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
+Cc: Alexander Aring <aahringo@redhat.com>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Stable-dep-of: 13e55fbaec17 ("net: ipv6: fix dst ref loop on input in rpl lwt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv6/rpl_iptunnel.c | 46 ++++++++++++++++++++++-------------------
+ 1 file changed, 25 insertions(+), 21 deletions(-)
+
+diff --git a/net/ipv6/rpl_iptunnel.c b/net/ipv6/rpl_iptunnel.c
+index df835dfcc5b70..dbdfdd2e52784 100644
+--- a/net/ipv6/rpl_iptunnel.c
++++ b/net/ipv6/rpl_iptunnel.c
+@@ -125,7 +125,8 @@ static void rpl_destroy_state(struct lwtunnel_state *lwt)
+ }
+ static int rpl_do_srh_inline(struct sk_buff *skb, const struct rpl_lwt *rlwt,
+-                           const struct ipv6_rpl_sr_hdr *srh)
++                           const struct ipv6_rpl_sr_hdr *srh,
++                           struct dst_entry *cache_dst)
+ {
+       struct ipv6_rpl_sr_hdr *isrh, *csrh;
+       const struct ipv6hdr *oldhdr;
+@@ -153,7 +154,7 @@ static int rpl_do_srh_inline(struct sk_buff *skb, const struct rpl_lwt *rlwt,
+       hdrlen = ((csrh->hdrlen + 1) << 3);
+-      err = skb_cow_head(skb, hdrlen + skb->mac_len);
++      err = skb_cow_head(skb, hdrlen + dst_dev_overhead(cache_dst, skb));
+       if (unlikely(err)) {
+               kfree(buf);
+               return err;
+@@ -186,7 +187,8 @@ static int rpl_do_srh_inline(struct sk_buff *skb, const struct rpl_lwt *rlwt,
+       return 0;
+ }
+-static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt)
++static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt,
++                    struct dst_entry *cache_dst)
+ {
+       struct dst_entry *dst = skb_dst(skb);
+       struct rpl_iptunnel_encap *tinfo;
+@@ -196,7 +198,7 @@ static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt)
+       tinfo = rpl_encap_lwtunnel(dst->lwtstate);
+-      return rpl_do_srh_inline(skb, rlwt, tinfo->srh);
++      return rpl_do_srh_inline(skb, rlwt, tinfo->srh, cache_dst);
+ }
+ static int rpl_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+@@ -208,14 +210,14 @@ static int rpl_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+       rlwt = rpl_lwt_lwtunnel(orig_dst->lwtstate);
+-      err = rpl_do_srh(skb, rlwt);
+-      if (unlikely(err))
+-              goto drop;
+-
+       local_bh_disable();
+       dst = dst_cache_get(&rlwt->cache);
+       local_bh_enable();
++      err = rpl_do_srh(skb, rlwt, dst);
++      if (unlikely(err))
++              goto drop;
++
+       if (unlikely(!dst)) {
+               struct ipv6hdr *hdr = ipv6_hdr(skb);
+               struct flowi6 fl6;
+@@ -237,15 +239,15 @@ static int rpl_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+               local_bh_disable();
+               dst_cache_set_ip6(&rlwt->cache, dst, &fl6.saddr);
+               local_bh_enable();
++
++              err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
++              if (unlikely(err))
++                      goto drop;
+       }
+       skb_dst_drop(skb);
+       skb_dst_set(skb, dst);
+-      err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
+-      if (unlikely(err))
+-              goto drop;
+-
+       return dst_output(net, sk, skb);
+ drop:
+@@ -262,12 +264,13 @@ static int rpl_input(struct sk_buff *skb)
+       rlwt = rpl_lwt_lwtunnel(orig_dst->lwtstate);
+-      err = rpl_do_srh(skb, rlwt);
+-      if (unlikely(err))
+-              goto drop;
+-
+       local_bh_disable();
+       dst = dst_cache_get(&rlwt->cache);
++      local_bh_enable();
++
++      err = rpl_do_srh(skb, rlwt, dst);
++      if (unlikely(err))
++              goto drop;
+       skb_dst_drop(skb);
+@@ -275,17 +278,18 @@ static int rpl_input(struct sk_buff *skb)
+               ip6_route_input(skb);
+               dst = skb_dst(skb);
+               if (!dst->error) {
++                      local_bh_disable();
+                       dst_cache_set_ip6(&rlwt->cache, dst,
+                                         &ipv6_hdr(skb)->saddr);
++                      local_bh_enable();
+               }
++
++              err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
++              if (unlikely(err))
++                      goto drop;
+       } else {
+               skb_dst_set(skb, dst);
+       }
+-      local_bh_enable();
+-
+-      err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
+-      if (unlikely(err))
+-              goto drop;
+       return dst_input(skb);
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-ipv6-rpl_iptunnel-simplify-the-return-expression.patch b/queue-5.10/net-ipv6-rpl_iptunnel-simplify-the-return-expression.patch
new file mode 100644 (file)
index 0000000..cbc86e7
--- /dev/null
@@ -0,0 +1,47 @@
+From f448317ecab5aebc47c15f0bf4a695bd5029e396 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 8 Dec 2020 20:09:49 +0800
+Subject: net: ipv6: rpl_iptunnel: simplify the return expression of
+ rpl_do_srh()
+
+From: Zheng Yongjun <zhengyongjun3@huawei.com>
+
+[ Upstream commit 9faad250ce66ed4159fa095a269690d7cfdb3ce3 ]
+
+Simplify the return expression.
+
+Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Stable-dep-of: 13e55fbaec17 ("net: ipv6: fix dst ref loop on input in rpl lwt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv6/rpl_iptunnel.c | 7 +------
+ 1 file changed, 1 insertion(+), 6 deletions(-)
+
+diff --git a/net/ipv6/rpl_iptunnel.c b/net/ipv6/rpl_iptunnel.c
+index 274593b7c6107..df835dfcc5b70 100644
+--- a/net/ipv6/rpl_iptunnel.c
++++ b/net/ipv6/rpl_iptunnel.c
+@@ -190,18 +190,13 @@ static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt)
+ {
+       struct dst_entry *dst = skb_dst(skb);
+       struct rpl_iptunnel_encap *tinfo;
+-      int err = 0;
+       if (skb->protocol != htons(ETH_P_IPV6))
+               return -EINVAL;
+       tinfo = rpl_encap_lwtunnel(dst->lwtstate);
+-      err = rpl_do_srh_inline(skb, rlwt, tinfo->srh);
+-      if (err)
+-              return err;
+-
+-      return 0;
++      return rpl_do_srh_inline(skb, rlwt, tinfo->srh);
+ }
+ static int rpl_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-loopback-avoid-sending-ip-packets-without-an-eth.patch b/queue-5.10/net-loopback-avoid-sending-ip-packets-without-an-eth.patch
new file mode 100644 (file)
index 0000000..83bb1a2
--- /dev/null
@@ -0,0 +1,94 @@
+From 5567ed0a32380f53968bfec1af43e7ecbdf9d457 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Thu, 20 Feb 2025 09:25:59 +0200
+Subject: net: loopback: Avoid sending IP packets without an Ethernet header
+
+From: Ido Schimmel <idosch@nvidia.com>
+
+[ Upstream commit 0e4427f8f587c4b603475468bb3aee9418574893 ]
+
+After commit 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
+IPv4 neighbors can be constructed on the blackhole net device, but they
+are constructed with an output function (neigh_direct_output()) that
+simply calls dev_queue_xmit(). The latter will transmit packets via
+'skb->dev' which might not be the blackhole net device if dst_dev_put()
+switched 'dst->dev' to the blackhole net device while another CPU was
+using the dst entry in ip_output(), but after it already initialized
+'skb->dev' from 'dst->dev'.
+
+Specifically, the following can happen:
+
+    CPU1                                      CPU2
+
+udp_sendmsg(sk1)                          udp_sendmsg(sk2)
+udp_send_skb()                            [...]
+ip_output()
+    skb->dev = skb_dst(skb)->dev
+                                          dst_dev_put()
+                                              dst->dev = blackhole_netdev
+ip_finish_output2()
+    resolves neigh on dst->dev
+neigh_output()
+neigh_direct_output()
+dev_queue_xmit()
+
+This will result in IPv4 packets being sent without an Ethernet header
+via a valid net device:
+
+tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
+listening on enp9s0, link-type EN10MB (Ethernet), snapshot length 262144 bytes
+22:07:02.329668 20:00:40:11:18:fb > 45:00:00:44:f4:94, ethertype Unknown
+(0x58c6), length 68:
+        0x0000:  8dda 74ca f1ae ca6c ca6c 0098 969c 0400  ..t....l.l......
+        0x0010:  0000 4730 3f18 6800 0000 0000 0000 9971  ..G0?.h........q
+        0x0020:  c4c9 9055 a157 0a70 9ead bf83 38ca ab38  ...U.W.p....8..8
+        0x0030:  8add ab96 e052                           .....R
+
+Fix by making sure that neighbors are constructed on top of the
+blackhole net device with an output function that simply consumes the
+packets, in a similar fashion to dst_discard_out() and
+blackhole_netdev_xmit().
+
+Fixes: 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to invalidate dst entries")
+Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
+Reported-by: Florian Meister <fmei@sfs.com>
+Closes: https://lore.kernel.org/netdev/20250210084931.23a5c2e4@hermes.local/
+Signed-off-by: Ido Schimmel <idosch@nvidia.com>
+Reviewed-by: Eric Dumazet <edumazet@google.com>
+Link: https://patch.msgid.link/20250220072559.782296-1-idosch@nvidia.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/net/loopback.c | 14 ++++++++++++++
+ 1 file changed, 14 insertions(+)
+
+diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
+index 498e5c8013efb..0160a4f57ce92 100644
+--- a/drivers/net/loopback.c
++++ b/drivers/net/loopback.c
+@@ -243,8 +243,22 @@ static netdev_tx_t blackhole_netdev_xmit(struct sk_buff *skb,
+       return NETDEV_TX_OK;
+ }
++static int blackhole_neigh_output(struct neighbour *n, struct sk_buff *skb)
++{
++      kfree_skb(skb);
++      return 0;
++}
++
++static int blackhole_neigh_construct(struct net_device *dev,
++                                   struct neighbour *n)
++{
++      n->output = blackhole_neigh_output;
++      return 0;
++}
++
+ static const struct net_device_ops blackhole_netdev_ops = {
+       .ndo_start_xmit = blackhole_netdev_xmit,
++      .ndo_neigh_construct = blackhole_neigh_construct,
+ };
+ /* This is a dst-dummy device used specifically for invalidated
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-mvpp2-cls-fixed-non-ip-flow-with-vlan-tag-flow-d.patch b/queue-5.10/net-mvpp2-cls-fixed-non-ip-flow-with-vlan-tag-flow-d.patch
new file mode 100644 (file)
index 0000000..dc5e756
--- /dev/null
@@ -0,0 +1,40 @@
+From 67024bc8be659e16ec7e301bd7e3a973cb618eec Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 24 Feb 2025 20:20:58 -0800
+Subject: net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.
+
+From: Harshal Chaudhari <hchaudhari@marvell.com>
+
+[ Upstream commit 2d253726ff7106b39a44483b6864398bba8a2f74 ]
+
+Non IP flow, with vlan tag not working as expected while
+running below command for vlan-priority. fixed that.
+
+ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0
+
+Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.")
+Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com>
+Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
+Link: https://patch.msgid.link/20250225042058.2643838-1-hchaudhari@marvell.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+index 41d935d1aaf6f..3ad1327395877 100644
+--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
++++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+@@ -318,7 +318,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = {
+                      MVPP2_PRS_RI_VLAN_MASK),
+       /* Non IP flow, with vlan tag */
+       MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG,
+-                     MVPP22_CLS_HEK_OPT_VLAN,
++                     MVPP22_CLS_HEK_TAGGED,
+                      0, 0),
+ };
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-use-indirect-call-helpers-for-dst_input.patch b/queue-5.10/net-use-indirect-call-helpers-for-dst_input.patch
new file mode 100644 (file)
index 0000000..9d2ef8f
--- /dev/null
@@ -0,0 +1,63 @@
+From 66b3bd382c7fec8697171b736591181e7c19c9c0 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 1 Feb 2021 17:41:29 +0000
+Subject: net: use indirect call helpers for dst_input
+
+From: Brian Vazquez <brianvv@google.com>
+
+[ Upstream commit e43b21906439ed14dda84f9784d38c03d0464607 ]
+
+This patch avoids the indirect call for the common case:
+ip_local_deliver and ip6_input
+
+Signed-off-by: Brian Vazquez <brianvv@google.com>
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Stable-dep-of: 13e55fbaec17 ("net: ipv6: fix dst ref loop on input in rpl lwt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ include/net/dst.h   | 6 +++++-
+ net/ipv4/ip_input.c | 1 +
+ 2 files changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/include/net/dst.h b/include/net/dst.h
+index 48e613420b952..907b4b5893a67 100644
+--- a/include/net/dst.h
++++ b/include/net/dst.h
+@@ -18,6 +18,7 @@
+ #include <linux/refcount.h>
+ #include <net/neighbour.h>
+ #include <asm/processor.h>
++#include <linux/indirect_call_wrapper.h>
+ struct sk_buff;
+@@ -436,10 +437,13 @@ static inline int dst_output(struct net *net, struct sock *sk, struct sk_buff *s
+       return skb_dst(skb)->output(net, sk, skb);
+ }
++INDIRECT_CALLABLE_DECLARE(int ip6_input(struct sk_buff *));
++INDIRECT_CALLABLE_DECLARE(int ip_local_deliver(struct sk_buff *));
+ /* Input packet from network to transport.  */
+ static inline int dst_input(struct sk_buff *skb)
+ {
+-      return skb_dst(skb)->input(skb);
++      return INDIRECT_CALL_INET(skb_dst(skb)->input,
++                                ip6_input, ip_local_deliver, skb);
+ }
+ static inline struct dst_entry *dst_check(struct dst_entry *dst, u32 cookie)
+diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
+index 372579686162b..3109bf6cdf283 100644
+--- a/net/ipv4/ip_input.c
++++ b/net/ipv4/ip_input.c
+@@ -253,6 +253,7 @@ int ip_local_deliver(struct sk_buff *skb)
+                      net, NULL, skb, skb->dev, NULL,
+                      ip_local_deliver_finish);
+ }
++EXPORT_SYMBOL(ip_local_deliver);
+ static inline bool ip_rcv_options(struct sk_buff *skb, struct net_device *dev)
+ {
+-- 
+2.39.5
+
diff --git a/queue-5.10/net-use-indirect-call-helpers-for-dst_output.patch b/queue-5.10/net-use-indirect-call-helpers-for-dst_output.patch
new file mode 100644 (file)
index 0000000..7ee8a97
--- /dev/null
@@ -0,0 +1,71 @@
+From 247645493d2852a79ea0ffe6e3a8f5b698cf7b29 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 1 Feb 2021 17:41:30 +0000
+Subject: net: use indirect call helpers for dst_output
+
+From: Brian Vazquez <brianvv@google.com>
+
+[ Upstream commit 6585d7dc491d9d5e323ed52ee32ad071e04c9dfa ]
+
+This patch avoids the indirect call for the common case:
+ip6_output and ip_output
+
+Signed-off-by: Brian Vazquez <brianvv@google.com>
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Stable-dep-of: 13e55fbaec17 ("net: ipv6: fix dst ref loop on input in rpl lwt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ include/net/dst.h     | 8 +++++++-
+ net/ipv4/ip_output.c  | 1 +
+ net/ipv6/ip6_output.c | 1 +
+ 3 files changed, 9 insertions(+), 1 deletion(-)
+
+diff --git a/include/net/dst.h b/include/net/dst.h
+index 907b4b5893a67..af57a6284444c 100644
+--- a/include/net/dst.h
++++ b/include/net/dst.h
+@@ -431,10 +431,16 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout)
+               dst->expires = expires;
+ }
++INDIRECT_CALLABLE_DECLARE(int ip6_output(struct net *, struct sock *,
++                                       struct sk_buff *));
++INDIRECT_CALLABLE_DECLARE(int ip_output(struct net *, struct sock *,
++                                       struct sk_buff *));
+ /* Output packet to network from transport.  */
+ static inline int dst_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+ {
+-      return skb_dst(skb)->output(net, sk, skb);
++      return INDIRECT_CALL_INET(skb_dst(skb)->output,
++                                ip6_output, ip_output,
++                                net, sk, skb);
+ }
+ INDIRECT_CALLABLE_DECLARE(int ip6_input(struct sk_buff *));
+diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
+index 12ee857d6cfe4..1e430e135aa60 100644
+--- a/net/ipv4/ip_output.c
++++ b/net/ipv4/ip_output.c
+@@ -441,6 +441,7 @@ int ip_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+                           ip_finish_output,
+                           !(IPCB(skb)->flags & IPSKB_REROUTED));
+ }
++EXPORT_SYMBOL(ip_output);
+ /*
+  * copy saddr and daddr, possibly using 64bit load/stores
+diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
+index 4da3238836b73..5003c5a23fa70 100644
+--- a/net/ipv6/ip6_output.c
++++ b/net/ipv6/ip6_output.c
+@@ -236,6 +236,7 @@ int ip6_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+                           ip6_finish_output,
+                           !(IP6CB(skb)->flags & IP6SKB_REROUTED));
+ }
++EXPORT_SYMBOL(ip6_output);
+ bool ip6_autoflowlabel(struct net *net, const struct ipv6_pinfo *np)
+ {
+-- 
+2.39.5
+
index f2d37898c67cd9573cf59564641bb04a0374b2e9..fa49d94e20caa7fcbca4b0df2efd4972dd63e12b 100644 (file)
@@ -365,3 +365,17 @@ x86-cpu-kvm-srso-fix-possible-missing-ibpb-on-vm-exit.patch
 ib-mlx5-set-and-get-correct-qp_num-for-a-dct-qp.patch
 rdma-mlx5-fix-bind-qp-error-cleanup-flow.patch
 sunrpc-suppress-warnings-for-unused-procfs-functions.patch
+alsa-usb-audio-avoid-dropping-midi-events-at-closing.patch
+bluetooth-l2cap-fix-l2cap_ecred_conn_rsp-response.patch
+net-loopback-avoid-sending-ip-packets-without-an-eth.patch
+net-cadence-macb-synchronize-stats-calculations.patch
+asoc-es8328-fix-route-from-dac-to-output.patch
+ipvs-always-clear-ipvs_property-flag-in-skb_scrub_pa.patch
+tcp-defer-ts_recent-changes-until-req-is-owned.patch
+net-mvpp2-cls-fixed-non-ip-flow-with-vlan-tag-flow-d.patch
+net-ipv6-rpl_iptunnel-simplify-the-return-expression.patch
+net-use-indirect-call-helpers-for-dst_input.patch
+net-use-indirect-call-helpers-for-dst_output.patch
+include-net-add-static-inline-dst_dev_overhead-to-ds.patch
+net-ipv6-rpl_iptunnel-mitigate-2-realloc-issue.patch
+net-ipv6-fix-dst-ref-loop-on-input-in-rpl-lwt.patch
diff --git a/queue-5.10/tcp-defer-ts_recent-changes-until-req-is-owned.patch b/queue-5.10/tcp-defer-ts_recent-changes-until-req-is-owned.patch
new file mode 100644 (file)
index 0000000..a914c60
--- /dev/null
@@ -0,0 +1,92 @@
+From 9107248b342e00158b70a5f96b671b895b2311ee Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 24 Feb 2025 17:00:47 +0800
+Subject: tcp: Defer ts_recent changes until req is owned
+
+From: Wang Hai <wanghai38@huawei.com>
+
+[ Upstream commit 8d52da23b6c68a0f6bad83959ebb61a2cf623c4e ]
+
+Recently a bug was discovered where the server had entered TCP_ESTABLISHED
+state, but the upper layers were not notified.
+
+The same 5-tuple packet may be processed by different CPUSs, so two
+CPUs may receive different ack packets at the same time when the
+state is TCP_NEW_SYN_RECV.
+
+In that case, req->ts_recent in tcp_check_req may be changed concurrently,
+which will probably cause the newsk's ts_recent to be incorrectly large.
+So that tcp_validate_incoming will fail. At this point, newsk will not be
+able to enter the TCP_ESTABLISHED.
+
+cpu1                                    cpu2
+tcp_check_req
+                                        tcp_check_req
+ req->ts_recent = rcv_tsval = t1
+                                         req->ts_recent = rcv_tsval = t2
+
+ syn_recv_sock
+  tcp_sk(child)->rx_opt.ts_recent = req->ts_recent = t2 // t1 < t2
+tcp_child_process
+ tcp_rcv_state_process
+  tcp_validate_incoming
+   tcp_paws_check
+    if ((s32)(rx_opt->ts_recent - rx_opt->rcv_tsval) <= paws_win)
+        // t2 - t1 > paws_win, failed
+                                        tcp_v4_do_rcv
+                                         tcp_rcv_state_process
+                                         // TCP_ESTABLISHED
+
+The cpu2's skb or a newly received skb will call tcp_v4_do_rcv to get
+the newsk into the TCP_ESTABLISHED state, but at this point it is no
+longer possible to notify the upper layer application. A notification
+mechanism could be added here, but the fix is more complex, so the
+current fix is used.
+
+In tcp_check_req, req->ts_recent is used to assign a value to
+tcp_sk(child)->rx_opt.ts_recent, so removing the change in req->ts_recent
+and changing tcp_sk(child)->rx_opt.ts_recent directly after owning the
+req fixes this bug.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Wang Hai <wanghai38@huawei.com>
+Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
+Reviewed-by: Eric Dumazet <edumazet@google.com>
+Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv4/tcp_minisocks.c | 10 ++++------
+ 1 file changed, 4 insertions(+), 6 deletions(-)
+
+diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
+index 01e27620b7ee5..866055e1b8014 100644
+--- a/net/ipv4/tcp_minisocks.c
++++ b/net/ipv4/tcp_minisocks.c
+@@ -726,12 +726,6 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
+       /* In sequence, PAWS is OK. */
+-      /* TODO: We probably should defer ts_recent change once
+-       * we take ownership of @req.
+-       */
+-      if (tmp_opt.saw_tstamp && !after(TCP_SKB_CB(skb)->seq, tcp_rsk(req)->rcv_nxt))
+-              WRITE_ONCE(req->ts_recent, tmp_opt.rcv_tsval);
+-
+       if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn) {
+               /* Truncate SYN, it is out of window starting
+                  at tcp_rsk(req)->rcv_isn + 1. */
+@@ -780,6 +774,10 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
+       if (!child)
+               goto listen_overflow;
++      if (own_req && tmp_opt.saw_tstamp &&
++          !after(TCP_SKB_CB(skb)->seq, tcp_rsk(req)->rcv_nxt))
++              tcp_sk(child)->rx_opt.ts_recent = tmp_opt.rcv_tsval;
++
+       if (own_req && rsk_drop_req(req)) {
+               reqsk_queue_removed(&inet_csk(sk)->icsk_accept_queue, req);
+               inet_csk_reqsk_queue_drop_and_put(sk, req);
+-- 
+2.39.5
+