]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
tools/rmmod: return EXIT_FAILURE if kmod_module_new_* fails
authorEmil Velikov <emil.l.velikov@gmail.com>
Wed, 18 Sep 2024 15:49:08 +0000 (16:49 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Sat, 21 Sep 2024 15:53:12 +0000 (10:53 -0500)
In the unlikely case where kmod_module_new_from_{path,name} fails,
rmmod will return success. Change that to EXIT_FAILURE.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/138
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
tools/rmmod.c

index 2d82c8604f92ca0ffd0bfeacead83771cbea83ff..5246bad3c05c2b39de73c542b6896ccac6f6ca55 100644 (file)
@@ -156,6 +156,7 @@ static int do_rmmod(int argc, char *argv[])
                if (err < 0) {
                        ERR("could not use module %s: %s\n", arg,
                            strerror(-err));
+                       r = EXIT_FAILURE;
                        break;
                }