]> git.ipfire.org Git - thirdparty/git.git/commitdiff
pack-objects: swap 'show_{object,commit}_pack_hint'
authorTaylor Blau <me@ttaylorr.com>
Mon, 23 Jun 2025 22:32:27 +0000 (18:32 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 23 Jun 2025 22:41:37 +0000 (15:41 -0700)
show_commit_pack_hint() has heretofore been a noop, so its position
within its compilation unit only needs to appear before its first use.

But the following commit will sometimes have `show_commit_pack_hint()`
call `show_object_pack_hint()`, so reorder the former to appear after
the latter to minimize the code movement in that patch.

Suggested-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/pack-objects.c

index 9580b4ea1a1539b5b746a16e8b76ab9eae98306e..f44447a3f9caf3f806b44690ba72a0b92cfc9957 100644 (file)
@@ -3748,12 +3748,6 @@ static int add_object_entry_from_pack(const struct object_id *oid,
        return 0;
 }
 
-static void show_commit_pack_hint(struct commit *commit UNUSED,
-                                 void *data UNUSED)
-{
-       /* nothing to do; commits don't have a namehash */
-}
-
 static void show_object_pack_hint(struct object *object, const char *name,
                                  void *data UNUSED)
 {
@@ -3776,6 +3770,12 @@ static void show_object_pack_hint(struct object *object, const char *name,
        stdin_packs_hints_nr++;
 }
 
+static void show_commit_pack_hint(struct commit *commit UNUSED,
+                                 void *data UNUSED)
+{
+       /* nothing to do; commits don't have a namehash */
+}
+
 static int pack_mtime_cmp(const void *_a, const void *_b)
 {
        struct packed_git *a = ((const struct string_list_item*)_a)->util;