]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail()
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 14:43:27 +0000 (15:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 19 Feb 2025 15:59:14 +0000 (16:59 +0100)
drm_atomic_helper_commit_tail() is the final part of an atomic commit,
and is given a parameter with the drm_atomic_state being committed.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-8-e71598f49c8f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_atomic_helper.c

index 512f10c4b6aaf21b44711e7f99c682cc15587212..70354f223daf52ffb7a651870c68d0835199418f 100644 (file)
@@ -1768,7 +1768,7 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
 
 /**
  * drm_atomic_helper_commit_tail - commit atomic update to hardware
- * @old_state: atomic state object with old state structures
+ * @state: atomic state object being committed
  *
  * This is the default implementation for the
  * &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
@@ -1779,23 +1779,23 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
  * Note that the default ordering of how the various stages are called is to
  * match the legacy modeset helper library closest.
  */
-void drm_atomic_helper_commit_tail(struct drm_atomic_state *old_state)
+void drm_atomic_helper_commit_tail(struct drm_atomic_state *state)
 {
-       struct drm_device *dev = old_state->dev;
+       struct drm_device *dev = state->dev;
 
-       drm_atomic_helper_commit_modeset_disables(dev, old_state);
+       drm_atomic_helper_commit_modeset_disables(dev, state);
 
-       drm_atomic_helper_commit_planes(dev, old_state, 0);
+       drm_atomic_helper_commit_planes(dev, state, 0);
 
-       drm_atomic_helper_commit_modeset_enables(dev, old_state);
+       drm_atomic_helper_commit_modeset_enables(dev, state);
 
-       drm_atomic_helper_fake_vblank(old_state);
+       drm_atomic_helper_fake_vblank(state);
 
-       drm_atomic_helper_commit_hw_done(old_state);
+       drm_atomic_helper_commit_hw_done(state);
 
-       drm_atomic_helper_wait_for_vblanks(dev, old_state);
+       drm_atomic_helper_wait_for_vblanks(dev, state);
 
-       drm_atomic_helper_cleanup_planes(dev, old_state);
+       drm_atomic_helper_cleanup_planes(dev, state);
 }
 EXPORT_SYMBOL(drm_atomic_helper_commit_tail);