]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
super: don't bother with WARN_ON_ONCE()
authorChristian Brauner <brauner@kernel.org>
Mon, 27 Nov 2023 11:51:31 +0000 (12:51 +0100)
committerChristian Brauner <brauner@kernel.org>
Tue, 28 Nov 2023 18:15:37 +0000 (19:15 +0100)
We hold our own active reference and we've checked it above.

Link: https://lore.kernel.org/r/20231127-vfs-super-massage-wait-v1-2-9ab277bfd01a@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/super.c

index 9cfe9c379c3f3189a274782a95d93f5120a6a6ad..1745cf7ea0052e0256acecd7a68ab7e89c3d6900 100644 (file)
@@ -2067,10 +2067,7 @@ retry:
        /* Release s_umount to preserve sb_start_write -> s_umount ordering */
        super_unlock_excl(sb);
        sb_wait_write(sb, SB_FREEZE_WRITE);
-       if (!super_lock_excl(sb)) {
-               WARN_ON_ONCE("Dying superblock while freezing!");
-               return -EINVAL;
-       }
+       __super_lock_excl(sb);
 
        /* Now we go and block page faults... */
        sb->s_writers.frozen = SB_FREEZE_PAGEFAULT;