]> git.ipfire.org Git - thirdparty/newt.git/commitdiff
fix warnings about never-read values
authorMiroslav Lichvar <mlichvar@redhat.com>
Tue, 1 Oct 2019 17:02:58 +0000 (19:02 +0200)
committerMiroslav Lichvar <mlichvar@redhat.com>
Tue, 1 Oct 2019 17:13:55 +0000 (19:13 +0200)
grid.c
listbox.c
newt.c
whiptail.c
windows.c

diff --git a/grid.c b/grid.c
index 5b4b1202c40ce90b91d3725d4695b4900aa1d560..6f79ce46ada78f9123b52fc987cabe6c818602bf 100644 (file)
--- a/grid.c
+++ b/grid.c
@@ -158,7 +158,6 @@ static void shuffleGrid(newtGrid grid, int left, int top, int set) {
 
     thisTop = top;
     for (row = 0; row < grid->rows; row++) {
-       i = 0;
        thisLeft = left;
        for (col = 0; col < grid->cols; col++) {
            field = &grid->fields[col][row];
index 6177c07fddf1c5ced3008b6e490da176329808ab..aae4f836f7c108b02ca93de826fe3a1800637c85 100644 (file)
--- a/listbox.c
+++ b/listbox.c
@@ -758,7 +758,7 @@ static void listboxDestroy(newtComponent co) {
     struct listbox * li = co->data;
     struct items * item, * nextitem;
 
-    nextitem = item = li->boxItems;
+    item = li->boxItems;
 
     while (item != NULL) {
        nextitem = item->next;
diff --git a/newt.c b/newt.c
index 0a6ca914a9dc059180e5496c42fdf0a7dfc41271..c1dd916db1b4b56ea549aa947572daf7bd6d922a 100644 (file)
--- a/newt.c
+++ b/newt.c
@@ -873,8 +873,6 @@ void newtPopWindowNoRefresh(void) {
     if (currentWindow == NULL)
        return;
 
-    row = col = 0;
-
     row = currentWindow->top - 1;
     col = currentWindow->left - 2;
     if (row < 0)
index 7932d8b3a1d438c442d12e315dd425e76a27a65b..627f1eeee598e759db564b13534571b120f22c3d 100644 (file)
@@ -346,7 +346,7 @@ int main(int argc, const char ** argv) {
     int fullButtons = 0;
     int outputfd = 2;
     int topLeft = 0;
-    FILE *output = stderr;
+    FILE *output;
     char * result;
     char ** selections, ** next;
     char * title = NULL;
index f1381ae716247dd5ba1fb9ab17a4fe748c09430b..29566a6bf553dda850cffb8b93b62b5e1768fe12 100644 (file)
--- a/windows.c
+++ b/windows.c
@@ -220,7 +220,6 @@ int newtWinEntries(char * title, char * text, int suggestedWidth, int flexDown,
 
     for (numItems = 0; items[numItems].text; numItems++); 
 
-    buttonName = button1;
     va_start(args, button1);
     for (buttonName = button1; buttonName; buttonName = va_arg(args, char *)) 
        ++totalButtons;