]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wireless: purelifi: plfxlc: fix memory leak in plfxlc_usb_wreq_asyn()
authorSalah Triki <salah.triki@gmail.com>
Sun, 27 Apr 2025 09:57:45 +0000 (10:57 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 8 May 2025 22:14:21 +0000 (00:14 +0200)
Add usb_free_urb() in the error path to prevent memory leak.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
Link: https://patch.msgid.link/aA3_maPlEJzO7wrL@pc
[fix subject]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/purelifi/plfxlc/usb.c

index 10d2e2124ff81a870a95e6644c8e61b0b40264cf..c2a1234b59db6c1c9e65a1f1594bc43a40edbd1a 100644 (file)
@@ -503,8 +503,10 @@ int plfxlc_usb_wreq_async(struct plfxlc_usb *usb, const u8 *buffer,
                          (void *)buffer, buffer_len, complete_fn, context);
 
        r = usb_submit_urb(urb, GFP_ATOMIC);
-       if (r)
+       if (r) {
+               usb_free_urb(urb);
                dev_err(&udev->dev, "Async write submit failed (%d)\n", r);
+       }
 
        return r;
 }