]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
posix: tst-spawn4-compat can be a regular test
authorFlorian Weimer <fweimer@redhat.com>
Tue, 9 Mar 2021 20:07:24 +0000 (21:07 +0100)
committerFlorian Weimer <fweimer@redhat.com>
Tue, 9 Mar 2021 20:07:24 +0000 (21:07 +0100)
compat_symbol_reference now works for non-internal tests, too.
Also stop building and running the tests on those architectures
that lack the test symbol versions.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
posix/Makefile
posix/tst-spawn4-compat.c

index 2ee5bb6e1d557a7caaffb213a31da319255b375a..305ec757cd797f1b47fc12b9d17f418f8b74b421 100644 (file)
@@ -110,9 +110,14 @@ ifeq ($(have-GLIBC_2.26)$(build-shared),yesyes)
 tests += tst-glob_lstat_compat
 endif
 
+# Test for the posix_spawn, posix_spawnp symbol versions replaced in
+# glibc 2.15.
+ifeq ($(have-GLIBC_2.14)$(build-shared),yesyes)
+tests += tst-spawn4-compat
+endif
+
 tests-internal := bug-regex5 bug-regex20 bug-regex33 \
-                  tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
-                  tst-spawn4-compat
+                  tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3
 tests-container := bug-ga2
 xtests         := tst-getaddrinfo4 tst-getaddrinfo5 tst-sched_rr_get_interval
 ifeq (yes,$(build-shared))
index 77f6ed6c22a6848655998bf6b9e5d3123edc2fc5..30ba0677ba6cce7a1a184ef9400633664a0c2d2c 100644 (file)
@@ -27,7 +27,6 @@
 #include <support/temp_file.h>
 
 #include <shlib-compat.h>
-#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_15)
 
 compat_symbol_reference (libc, posix_spawn, posix_spawn, GLIBC_2_2);
 compat_symbol_reference (libc, posix_spawnp, posix_spawnp, GLIBC_2_2);
@@ -66,12 +65,5 @@ do_test (void)
 
   return 0;
 }
-#else
-static int
-do_test (void)
-{
-  return 77;
-}
-#endif
 
 #include <support/test-driver.c>